fix(cli): preserve Alexandria receipts and clarify retries - #245
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alexandria executions now include an additive receipt containing actual reported credits, the client idempotency request ID, and the distinct server scrape ID. Print available charges and server IDs on stderr and preserve actionable status/code/action/retry metadata in failures.
Clarify that same-ID requests recover the same execution and replay completed results, including failures. Never automatically rotate an uncertain request ID.
Validation
TypeScript build and 35 focused tests passed. Three compact helper regressions cover receipt semantics, safe error serialization and retry-delay parsing; the existing compiled-CLI execution test verifies the receipt while retaining retry identity. No production calls.
Scope
Alexandria only. Ordinary URL scrape/search output, timeout, cache diagnostics and search --pretty were moved to draft #248. No API changes. This addresses the Alexandria portions of Exchange issues 548, 556 and CLI guidance in 544; it does not change server billing or replay semantics.