fix(search): scope developer search guidance and remove github category - #263
Conversation
Reject the github search category, document default web/news highlights, and describe developer coverage as public repositories.
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
Use the MCP developer sentence and default-highlights wording. Keep the zero-data-retention note on --highlights only, and switch the leftover github category fixture to developer.
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
The CLI has no enterprise flag, so the retention caveat cannot live on a ZDR option. Highlights help now matches the parameter, and the README intro states the default product.
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
Leave Jonathan's search description alone and advertise the highlights default on the flag, without the clunkier query-relevant wording.
There was a problem hiding this comment.
0 issues found across 5 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
|
@cubic-dev-ai review this PR |
@Max17190 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 6 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Removes github from accepted search categories (CLI validation/types/tests) and updates search/developer docs. --categories github now errors, so this is a user-visible behavior change that needs product/breaking-change sign-off.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Removes github from accepted search categories and updates help/docs/tests; existing --categories github calls now error. This is a public CLI contract change justified by the PR description rather than server-side evidence, so product sign-off is needed.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Removes github from accepted search categories and updates help, docs, types, and tests; existing --categories github calls now fail. This is a public CLI contract change lacking server-side evidence that github was unsupported, so human sign-off is needed.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Removes github from search categories and updates help, docs, and skill descriptions; existing --categories github calls now error. This public CLI contract change lacks server-side evidence that github was unsupported, so human review is needed.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Removes github from search categories and updates help/docs/skill descriptions; existing --categories github invocations now error. This public CLI contract change lacks server-side evidence that github was unsupported, so human review is needed.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Removes github from search category validation, types, and docs; --categories github now errors. This public CLI contract change lacks server-side evidence that the category was unsupported, so human sign-off is needed.
Re-trigger cubic
|
@cubic-dev-ai review this PR |
@Max17190 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 7 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Removes github from search category validation, types, and docs, so existing --categories github calls now error. Docs and tests are updated, but the diff lacks server-side evidence that the category is unsupported, so this public CLI contract change needs human sign-off.
Re-trigger cubic
Why
Search help should surface query-relevant highlights and distinguish public developer-index lookup from local code inspection. The search skill description should focus on source discovery. Category guidance and validation should expose supported choices.
Summary
--no-highlightsfor original snippets and--scrapefor full-page content.githubfrom category validation, types, and examples. Supported categories areresearch,pdf, anddeveloper.githuband supported categories in built CLI help.Test Plan
pnpm run buildpnpm run type-checkpnpm run format:checkenv -u FIRECRAWL_API_KEY pnpm test: 594 tests passed locally after merging current main.git diff --check