Skip to content

fix(search): scope developer search guidance and remove github category - #263

Merged
Max17190 merged 16 commits into
mainfrom
align-cli-search-highlights-developer
Sep 22, 2026
Merged

Max17190 merged 16 commits into
mainfrom
align-cli-search-highlights-developer

Conversation

@Max17190

@Max17190 Max17190 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Why

Search help should surface query-relevant highlights and distinguish public developer-index lookup from local code inspection. The search skill description should focus on source discovery. Category guidance and validation should expose supported choices.

Summary

  • Surface query-relevant highlights in the search command description and README, preserving existing tool-discovery guidance. Define highlights as page excerpts in the flag help, with defaults and availability details.
  • Retain --no-highlights for original snippets and --scrape for full-page content.
  • Clarify public developer-index coverage in help, documentation, and the search skill.
  • Narrow the developer-index skill's discovery description to public-source lookup for external documentation and upstream evidence. Its body is unchanged.
  • Describe highlights as query-relevant excerpts from the page in the search skill.
  • Focus the search skill description on source discovery with query-relevant excerpts and optional full-page content. Keep specialized-index links in the search skill body. The scrape skill is unchanged.
  • Remove github from category validation, types, and examples. Supported categories are research, pdf, and developer.
  • Cover rejection of github and supported categories in built CLI help.
  • Keep search execution and response formats unchanged apart from category validation.

Test Plan

  • pnpm run build
  • pnpm run type-check
  • pnpm run format:check
  • env -u FIRECRAWL_API_KEY pnpm test: 594 tests passed locally after merging current main.
  • Verify highlights and supported categories in built CLI help.
  • Validate developer-index and search skill frontmatter and formatting.
  • Verify the scrape skill is byte-for-byte identical to the PR base.
  • git diff --check

Reject the github search category, document default web/news highlights, and describe developer coverage as public repositories.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Shadow auto-approve: would not auto-approve because issues were found.

Fix all with cubic | Re-trigger cubic

Comment thread README.md Outdated
Use the MCP developer sentence and default-highlights wording. Keep the zero-data-retention note on --highlights only, and switch the leftover github category fixture to developer.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files (changes from recent commits).

Shadow auto-approve: would not auto-approve because issues were found.
Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic

Comment thread src/__tests__/commands/search.test.ts Outdated
Comment thread README.md Outdated
The CLI has no enterprise flag, so the retention caveat cannot live on a ZDR option. Highlights help now matches the parameter, and the README intro states the default product.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 4 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic

Leave Jonathan's search description alone and advertise the highlights default on the flag, without the clunkier query-relevant wording.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 5 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic

@Max17190

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@Max17190 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Shadow auto-approve: would not auto-approve because issues were found.

Fix all with cubic | Re-trigger cubic

Comment thread skills/firecrawl-search/SKILL.md
@Max17190 Max17190 changed the title fix(search): match MCP highlights and developer category fix(search): clarify default highlights in CLI help Sep 21, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files (changes from recent commits).

Shadow auto-approve: would not auto-approve because issues were found.
Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic

Comment thread src/index.ts
@Max17190 Max17190 changed the title fix(search): clarify default highlights in CLI help fix(search): scope developer search guidance and remove github category Sep 21, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 6 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Removes github from accepted search categories (CLI validation/types/tests) and updates search/developer docs. --categories github now errors, so this is a user-visible behavior change that needs product/breaking-change sign-off.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Removes github from accepted search categories and updates help/docs/tests; existing --categories github calls now error. This is a public CLI contract change justified by the PR description rather than server-side evidence, so product sign-off is needed.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Removes github from accepted search categories and updates help, docs, types, and tests; existing --categories github calls now fail. This is a public CLI contract change lacking server-side evidence that github was unsupported, so human sign-off is needed.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Removes github from search categories and updates help, docs, and skill descriptions; existing --categories github calls now error. This public CLI contract change lacks server-side evidence that github was unsupported, so human review is needed.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Removes github from search categories and updates help/docs/skill descriptions; existing --categories github invocations now error. This public CLI contract change lacks server-side evidence that github was unsupported, so human review is needed.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Removes github from search category validation, types, and docs; --categories github now errors. This public CLI contract change lacks server-side evidence that the category was unsupported, so human sign-off is needed.

Re-trigger cubic

@Max17190

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@Max17190 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Removes github from search category validation, types, and docs, so existing --categories github calls now error. Docs and tests are updated, but the diff lacks server-side evidence that the category is unsupported, so this public CLI contract change needs human sign-off.

Re-trigger cubic

@Max17190
Max17190 merged commit e7f9ea7 into main Sep 22, 2026
8 checks passed
@Max17190
Max17190 deleted the align-cli-search-highlights-developer branch September 22, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant