Fix & improve github.createTag - #15
Merged
Merged
Conversation
- Check was inverted (firstdarkdev#14) - Check was inefficient (firstdarkdev#12)
MattSturgeon
commented
Apr 4, 2024
Comment on lines
+112
to
+113
| // FIXME this check doesn't make sense when `github.draft` is true, | ||
| // because draft releases don't create a tag anyway... |
Contributor
Author
There was a problem hiding this comment.
This API was broken and is marked "experimental". Should we take this opportunity to change behaviour for the creating a draft scenario?
What do you think the best approach is?
- rename the option for clarity?
- just update the docs?
- add draft/public specific options?
- take a string/enum instead of a boolean?
Member
|
Hey. Just checking in. I've been so busy I forgot to check back on things. Is this PR ready to be merged, or do you have more you want to do first? |
Contributor
Author
No worries 👍
Should be good to go, unless you request any changes.
It doesn't address this comment or any of the ideas discussed in #16, but it does fix actual issues in the current implementation. Those other changes are out of scope of this PR, I think. |
hypherionmc
approved these changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the inverted logic and avoided the need to fetch all repo tags by using
getRefinstead.I tested out the
hasRefimplementation as follows:Details
Which prints:
Fixes #12
Fixes #14