fix(skills): monit 卡片里四个工具名不存在#91
Merged
Merged
Conversation
`monit-agent.md` ran `host.top` / `host.disk` and `monit.md` ran `host.cpu` / `host.mem`. None of the four exist. monit-agent v0.0.7 registers exactly: host → os.overview, os.top_processes, net.tcp_ping, http.get, shell.exec; mysql → mysql.overview, mysql.lock_contention, mysql.query. An agent copying these gets `unknown_tool`, and the `host.top` example also passed `limit`, which is not a parameter of anything (`os.top_processes` takes `top_n` / `sort_by`, and the agent validates with `additionalProperties:false`, so a wrong key is a hard `invalid_args`, not a silent no-op). The generated help in this repo (zz_generated_diagnostics.go, zz_generated_response_help.go) was already correct — only these hand-written cards drifted, because nothing checks their JSON bodies against the registry. Replacements verified live against a real dev target. Deliberately kept separate from the SDK-bump branch so it can land without waiting on that.
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skills/flashduty/reference/下两张手写卡片调用了四个根本不存在的工具。monit-agent.md:23host.top+host.diskmonit-agent.md:63host.top(params.limit) +host.disklimit不是任何工具的参数monit.md:68host.cpu+host.mem权威工具集(monit-agent v0.0.7 的
tool/包,即 monit-webapitoolregistry加载的那份):os.overview、os.top_processes、net.tcp_ping、http.get、shell.execmysql.overview、mysql.lock_contention、mysql.queryagent 照抄这些命令必然拿到
unknown_tool;limit那处即使工具名对了也会invalid_args——agent 用additionalProperties: false的编译期 jsonschema 校验,参数名错是硬失败不是静默忽略(os.top_processes的真实参数是top_n/sort_by)。本仓库生成的帮助文本(
zz_generated_*.go)是对的,只有这两张手写卡片漂了——因为没有任何东西会拿卡片里的 JSON body 去对照注册表校验。替换后的命令已打真实 dev 验证通过。
刻意不跟 SDK 升级那条分支放一起,那条要等 go-flashduty 合并;这条是线上硬失败,应该能单独先合。