Skip to content

feat: Nevermore Controller support - #1527

Merged
pedrolamas merged 1 commit into
fluidd-core:developfrom
pedrolamas:pedrolamas/nevermore-support
Nov 16, 2024
Merged

feat: Nevermore Controller support#1527
pedrolamas merged 1 commit into
fluidd-core:developfrom
pedrolamas:pedrolamas/nevermore-support

Conversation

@pedrolamas

@pedrolamas pedrolamas commented Nov 13, 2024

Copy link
Copy Markdown
Member

Adds full support for Nevermore Controller.

Replaces #1114

image

@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Nov 13, 2024
@pedrolamas pedrolamas added this to the 1.31 milestone Nov 13, 2024
@pedrolamas
pedrolamas force-pushed the pedrolamas/nevermore-support branch 2 times, most recently from d16af53 to be7b9b6 Compare November 13, 2024 17:30
'aht10',
'bme280',
'htu21d',
'nevermoresensor',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break VOC plotting on the temp graph.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just extra sensor data (does not include temperature, just pressure, humidity and gas)

@SanaaHamel

SanaaHamel commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

Note that there can be both nevermore <named> and nevermore objects, depending on how they are declared in the cfg.

@pedrolamas

Copy link
Copy Markdown
Member Author

Note that there can be both nevermore <named> and nevermore objects, depending on how they are declared in the cfg.

Yes, I made sure to handle both as shown on the screenshot

@pedrolamas
pedrolamas force-pushed the pedrolamas/nevermore-support branch from be7b9b6 to cea81cb Compare November 14, 2024 12:05
@pedrolamas

pedrolamas commented Nov 14, 2024

Copy link
Copy Markdown
Member Author

@SanaaHamel This is the test objects state I am using (and how I generated the screenshot bove):

{
  "nevermore": {
    "rpm": 10,
    "speed": 20,
    "intake_temperature": 20,
    "exhaust_temperature": 30,
    "intake_humidity": 40,
    "exhaust_humidity": 50,
    "intake_pressure": 60,
    "exhaust_pressure": 70,
    "intake_gas": 80,
    "exhaust_gas": 90
  },
  "nevermore test": {
    "rpm": 10,
    "speed": 20,
    "intake_temperature": 20,
    "exhaust_temperature": 30,
    "intake_humidity": 40,
    "exhaust_humidity": 50,
    "intake_pressure": 60,
    "exhaust_pressure": 70,
    "intake_gas": 80,
    "exhaust_gas": 90
  }
}

However, I was looking at the controller code and noticed a _min and _max for each entity (like intake_temperature_min, intake_temperature_max, ...), are those also reported as part of the Klipper status object?

Also, am I correct ti say "pressure" and "gas" are fully int values (have no decimals)?

@pedrolamas
pedrolamas force-pushed the pedrolamas/nevermore-support branch from cea81cb to 47cadc0 Compare November 15, 2024 12:15
@SanaaHamel

Copy link
Copy Markdown
Contributor

@SanaaHamel However, I was looking at the controller code and noticed a _min and _max for each entity (like intake_temperature_min, intake_temperature_max, ...), are those also reported as part of the Klipper status object?

They are. These were requested by Mainsail for future use. These indicated the upper/lower bound seen this klipper session.

@SanaaHamel Also, am I correct ti say "pressure" and "gas" are fully int values (have no decimals)?

gas is an integer, pressure is a float (recommend rounding for display) though it is pre-rounded in NevermoreSensor for historical reasons.

@pedrolamas
pedrolamas force-pushed the pedrolamas/nevermore-support branch from 47cadc0 to 5d3b166 Compare November 15, 2024 22:14
@pedrolamas

Copy link
Copy Markdown
Member Author

They are. These were requested by Mainsail for future use. These indicated the upper/lower bound seen this klipper session.

I've added support for them, they will show as tooltips for the gas, temperature, humidity, and pressure.

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas
pedrolamas force-pushed the pedrolamas/nevermore-support branch from 5d3b166 to edb3bc0 Compare November 16, 2024 14:47
@pedrolamas
pedrolamas marked this pull request as ready for review November 16, 2024 14:49

@SanaaHamel SanaaHamel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane. Passed smoke test w/ my production unit.

@pedrolamas

Copy link
Copy Markdown
Member Author

Thanks for testing and approving, @SanaaHamel! 🙂

@pedrolamas
pedrolamas requested a review from matmen November 16, 2024 15:48
@pedrolamas
pedrolamas merged commit ab16ea2 into fluidd-core:develop Nov 16, 2024
@pedrolamas
pedrolamas deleted the pedrolamas/nevermore-support branch November 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FR - Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants