feat: Nevermore Controller support - #1527
Conversation
d16af53 to
be7b9b6
Compare
| 'aht10', | ||
| 'bme280', | ||
| 'htu21d', | ||
| 'nevermoresensor', |
There was a problem hiding this comment.
This will break VOC plotting on the temp graph.
There was a problem hiding this comment.
This is just extra sensor data (does not include temperature, just pressure, humidity and gas)
|
Note that there can be both |
Yes, I made sure to handle both as shown on the screenshot |
be7b9b6 to
cea81cb
Compare
|
@SanaaHamel This is the test objects state I am using (and how I generated the screenshot bove): {
"nevermore": {
"rpm": 10,
"speed": 20,
"intake_temperature": 20,
"exhaust_temperature": 30,
"intake_humidity": 40,
"exhaust_humidity": 50,
"intake_pressure": 60,
"exhaust_pressure": 70,
"intake_gas": 80,
"exhaust_gas": 90
},
"nevermore test": {
"rpm": 10,
"speed": 20,
"intake_temperature": 20,
"exhaust_temperature": 30,
"intake_humidity": 40,
"exhaust_humidity": 50,
"intake_pressure": 60,
"exhaust_pressure": 70,
"intake_gas": 80,
"exhaust_gas": 90
}
}However, I was looking at the controller code and noticed a Also, am I correct ti say "pressure" and "gas" are fully int values (have no decimals)? |
cea81cb to
47cadc0
Compare
They are. These were requested by Mainsail for future use. These indicated the upper/lower bound seen this klipper session.
|
47cadc0 to
5d3b166
Compare
I've added support for them, they will show as tooltips for the gas, temperature, humidity, and pressure. |
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
5d3b166 to
edb3bc0
Compare
SanaaHamel
left a comment
There was a problem hiding this comment.
Looks sane. Passed smoke test w/ my production unit.
|
Thanks for testing and approving, @SanaaHamel! 🙂 |
Adds full support for Nevermore Controller.
Replaces #1114