fix(chart): point image repository at the org registry - #13
Draft
pallamidessi wants to merge 1 commit into
Draft
Conversation
The release workflow builds and pushes the image to ghcr.io/fluidstackio/chalert (IMAGE_NAME = github.repository) and the chart to oci://ghcr.io/fluidstackio/charts, but the chart still defaulted image.repository to the personal ghcr.io/garbett1/chalert, which has no current tags. Downstreams had to override image.repository to avoid ImagePullBackOff. Point the default (and the stale home/sources/README URLs) at the org registry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Default the chart's
image.repositorytoghcr.io/fluidstackio/chalert, and fix the stalehome/sources/README URLs that still referenced the personalgarbett1registry/repo.charts/chalert/values.yaml—image.repository: ghcr.io/garbett1/chalert → ghcr.io/fluidstackio/chalertcharts/chalert/Chart.yaml—home+sources→github.com/fluidstackio/chalertREADME.md— chart install path →oci://ghcr.io/fluidstackio/charts/chalertWhy
The release workflow already publishes:
ghcr.io/fluidstackio/chalert(IMAGE_NAME = github.repository)oci://ghcr.io/fluidstackio/charts…but the chart still defaulted the image to
ghcr.io/garbett1/chalert, which has no current tags (garbett1/chalert:0.5.0doesn't exist). Every downstream had to overrideimage.repositoryto avoid ImagePullBackOff (e.g. fluidstackio/systems#5257). This makes the default correct so they don't have to.Not included
github.com/garbett1/chalert) — that's a separate, invasive rename.version/appVersion/ imagetag— managed by release-please, left untouched.Follow-up
Once this releases, the
image.repositoryoverride in fluidstackio/systems#5257 can be dropped (thetagpin is still wanted there).