Skip to content

use egl platform display - #4

Merged
lhoward merged 1 commit into
flutter-elinux:masterfrom
wang-bin:eglplatform
Feb 5, 2026
Merged

lhoward merged 1 commit into
flutter-elinux:masterfrom
wang-bin:eglplatform

Conversation

@martinetd

Copy link
Copy Markdown

required if mutiple platforms are available, otherwise egl may call into x11 and crash even if gbm is desired. tested on rk3588

Comment thread src/flutter/shell/platform/linux_embedded/surface/environment_egl.h Outdated
Comment thread src/flutter/shell/platform/linux_embedded/surface/environment_egl.h Outdated
Comment thread src/flutter/shell/platform/linux_embedded/surface/environment_egl.h Outdated

@martinetd martinetd left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review!

@wang-bin The original PR was a bit old, do you still have time to update it?

Comment thread src/flutter/shell/platform/linux_embedded/surface/environment_egl.h Outdated
@wang-bin
wang-bin force-pushed the eglplatform branch 2 times, most recently from 6784ca7 to 3c508f1 Compare February 3, 2026 09:12
required if mutiple platforms are available, otherwise egl may call into
x11 and crash even if gbm is desired. tested on rk3588
@wang-bin

wang-bin commented Feb 3, 2026

Copy link
Copy Markdown

code is formatted by clang-format

@martinetd

Copy link
Copy Markdown
Author

Thank you, this looks good to me! (and tested on wayland on my PC)

@lhoward - please do the honors once you've had a look

@lhoward

lhoward commented Feb 5, 2026

Copy link
Copy Markdown

LGTM!

@lhoward
lhoward merged commit bf29354 into flutter-elinux:master Feb 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants