fix(ci): dart must be setup - #5098
Conversation
- includes a change to make `gh act` local development possible
|
Once this lands, I can update flutter/flutter#189020 |
There was a problem hiding this comment.
Code Review
This pull request updates the wait_for_tests composite action to set up the Dart SDK, dynamically resolve the action path to support local testing tools like nektos/act, and temporarily bypass workspace resolution by creating a pubspec_overrides.yaml file. Feedback on these changes highlights two issues with the temporary file cleanup: if dart pub get fails, the cleanup step is skipped, and the process can overwrite a developer's existing local overrides. It is recommended to use a trap to guarantee cleanup on exit and to back up any existing overrides file.
ievdokdm
left a comment
There was a problem hiding this comment.
other than gemini-code-assist suggestion LGTM
|
Addressed GCA feedback |
Action was missing "uses" clause to setup dart on the runner.
gh actlocal development possible