Skip to content

Moves test ownership validation to flutter/flutter - #188655

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
gaaclarke:test-ownership-move
Jun 29, 2026
Merged

Moves test ownership validation to flutter/flutter#188655
auto-submit[bot] merged 4 commits into
flutter:masterfrom
gaaclarke:test-ownership-move

Conversation

@gaaclarke

Copy link
Copy Markdown
Member

issue: #188640

This follows the pattern from #161249

This duplicates the logic of https://github.com/flutter/cocoon/blob/main/app_dart/bin/validate_task_ownership.dart

Note that the TESTOWNERS file format seems straightforward but it is actually weird where things that look like comments have semantic meaning.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Linux test_ownership target from .ci.yaml and introduces a new Dart test, test_ownership_validation_test.dart, to validate that all CI targets in .ci.yaml have a defined owner in TESTOWNERS. Feedback on the changes highlights a compile-time error caused by attempting to instantiate the abstract class YamlMap directly, and suggests using RegExp(r'\s+') instead of split(' ') to robustly handle multiple consecutive spaces when parsing target names and owners.

Comment thread dev/bots/test/test_ownership_validation_test.dart Outdated
Comment thread dev/bots/test/test_ownership_validation_test.dart Outdated
Comment thread dev/bots/test/test_ownership_validation_test.dart Outdated
Comment thread dev/bots/test/test_ownership_validation_test.dart Outdated
Comment thread dev/bots/test/test_ownership_validation_test.dart Outdated
Comment thread dev/bots/test/test_ownership_validation_test.dart Outdated
Comment thread dev/bots/test/test_ownership_validation_test.dart Outdated
Comment thread dev/bots/test/test_ownership_validation_test.dart Outdated
@gaaclarke

Copy link
Copy Markdown
Member Author
Screenshot 2026-06-29 at 9 06 01 AM

I verified it was hooked up to ci, when introducing a failure the following tests failed.

@gaaclarke
gaaclarke requested a review from jtmcdole June 29, 2026 16:49
@jtmcdole

Copy link
Copy Markdown
Member

Unpopular opinion, but I like:

  final isShard = switch ((recipe, tags?.contains('shard'), properties)) {
    ('flutter/flutter_drone', _, _) => true,
    (_, true, _) => true,
    (_, _, final p) when p['shard'] != null => true,
    _ => false,
  };

@gaaclarke

Copy link
Copy Markdown
Member Author

Oh yea, that's nice. I don't usually create new structures in order to send them to a match since I'm never sure if they are optimized away or not. It could be generating extra garbage.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Jun 29, 2026
Merged via the queue into flutter:master with commit 4e78d1b Jun 29, 2026
172 of 173 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jul 7, 2026
…#12081)

Manual roll Flutter from 0c80830e465b to ca9f874f5284 (119 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@0c80830...ca9f874

2026-06-30 34871572+gmackall@users.noreply.github.com [tool] Don't require a Flutter compile task when staging jniLibs (flutter/flutter#188805)
2026-06-30 jason-simmons@users.noreply.github.com [Impeller] Fix potential overflow when allocating buffers at the next power of two size (flutter/flutter#188742)
2026-06-30 bkonyi@google.com [Framework/Tool] Decouple preview theme imports (flutter/flutter#188176)
2026-06-30 kustermann@google.com Add import of `dart:_js_interop_wasm` in sdk rewriter tool (flutter/flutter#188620)
2026-06-30 15619084+vashworth@users.noreply.github.com Detach LLDB and print stack trace on process stop (flutter/flutter#188576)
2026-06-30 robert.ancell@canonical.com [Linux] Fix FlCompositorOpenGL.pixels comment (flutter/flutter#188754)
2026-06-30 bkonyi@google.com [flutter_tools] Fix crash in flutter create when pubspec.yaml is empty (flutter/flutter#188385)
2026-06-30 engine-flutter-autoroll@skia.org Roll Packages from 656ccaa to 274ed3e (23 revisions) (flutter/flutter#188792)
2026-06-30 jason-simmons@users.noreply.github.com In AndroidImageGenerator, check that the destination pixel buffer has sufficient capacity for the decoded data (flutter/flutter#188752)
2026-06-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#188773)
2026-06-30 bdero@google.com [Impeller] Add a flat VertexAttributeFormat for vertex inputs (flutter/flutter#188684)
2026-06-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#188764)
2026-06-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 0cb483880b6b to e1bdb9ce3327 (2 revisions) (flutter/flutter#188763)
2026-06-29 matt.boetger@gmail.com Handle 'no permissions' adb device state (flutter/flutter#187248)
2026-06-29 30870216+gaaclarke@users.noreply.github.com [windows]: adjusts uniform buffers to hit hlsl optimization (flutter/flutter#188538)
2026-06-29 engine-flutter-autoroll@skia.org Roll Skia from bfb7860cb9c7 to 71947c4110b0 (9 revisions) (flutter/flutter#188747)
2026-06-29 codefu@google.com ci: extract wait-for-engine-build logic into a reusable composite action (flutter/flutter#188748)
2026-06-29 okorohelijah@google.com Provide guided migration logs when iOS app crashes on simulator (flutter/flutter#188736)
2026-06-29 154381524+flutteractionsbot@users.noreply.github.com Revert "[flutter_tools] Track asset transformer dependencies for hot reload" (flutter/flutter#188751)
2026-06-29 34871572+gmackall@users.noreply.github.com Migrate ABI splits to new AGP dsl (flutter/flutter#188369)
2026-06-29 60122246+xiaowei-guan@users.noreply.github.com Add Impeller+OpenGLES startup benchmark for mokey (flutter/flutter#188495)
2026-06-29 louisehsu@google.com Increase macOS minimum supported version from 10.15 to 12 to support Xcode 27  (flutter/flutter#188520)
2026-06-29 30870216+gaaclarke@users.noreply.github.com Moves test ownership validation to flutter/flutter (flutter/flutter#188655)
2026-06-29 angy.avv.94@hotmail.it Add --flavor support for Windows desktop builds (flutter/flutter#187034)
2026-06-29 awolff@google.com Android_hardware_smoke_test: Enable pixel exact local file comparator to read goldens from flutter asset URI (flutter/flutter#188587)
2026-06-29 64674824+yashas-hm@users.noreply.github.com [flutter_tools] Use DeviceHub.app for iOS simulator path on Xcode 27+ (flutter/flutter#187910)
2026-06-29 engine-flutter-autoroll@skia.org Roll Skia from 111e7582d081 to bfb7860cb9c7 (2 revisions) (flutter/flutter#188731)
2026-06-29 jacksongardner@google.com Use `revert` label instead of `revert_wf` (flutter/flutter#188639)
2026-06-29 bkonyi@google.com Properly await Dart Development Service shutdown with timeout (flutter/flutter#188387)
2026-06-29 bkonyi@google.com [flutter_tools] Track asset transformer dependencies for hot reload (flutter/flutter#187947)
2026-06-29 bkonyi@google.com [Tool] Tolerate malformed UTF-8 in process streaming decoders (flutter/flutter#188453)
2026-06-29 nshahan@google.com [flutter_tools] Use new ddc modules in test (flutter/flutter#188240)
2026-06-29 engine-flutter-autoroll@skia.org Roll Packages from c1f7d92 to 656ccaa (12 revisions) (flutter/flutter#188728)
2026-06-29 robert.ancell@canonical.com Remove unused fields (flutter/flutter#188705)
2026-06-29 robert.ancell@canonical.com Clear text input handler widget on view dispose (flutter/flutter#188701)
2026-06-29 robert.ancell@canonical.com Free compositor in view renderer finalize to avoid use-after-free (flutter/flutter#188702)
2026-06-29 robert.ancell@canonical.com [linux] Use GWeakRef in mock signal handler test helper (flutter/flutter#188700)
2026-06-29 Rusino@users.noreply.github.com Fixing few related editing issues with LTR/RTL text (flutter/flutter#188503)
2026-06-29 bdero@google.com [Flutter GPU] Add Texture.fromImage to wrap a ui.Image texture (flutter/flutter#188605)
2026-06-29 bdero@google.com [Flutter GPU] Honor the enable argument in RenderPass.setDepthWriteEnable (flutter/flutter#188715)
2026-06-29 engine-flutter-autoroll@skia.org Roll Skia from ba1942d8c3e1 to 111e7582d081 (1 revision) (flutter/flutter#188721)
2026-06-29 engine-flutter-autoroll@skia.org Roll Skia from 587d8befe1ee to ba1942d8c3e1 (6 revisions) (flutter/flutter#188717)
2026-06-29 mosum@google.com Remove some refs to package:intl (flutter/flutter#188504)
2026-06-29 jhy03261997@gmail.com [VPAT] Update a11y assessment app FAB example to announce value change when it's updated. (flutter/flutter#188466)
...
kalyujniy pushed a commit to brickit-app/camera that referenced this pull request Jul 8, 2026
…flutter#12081)

Manual roll Flutter from 0c80830e465b to ca9f874f5284 (119 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@0c80830...ca9f874

2026-06-30 34871572+gmackall@users.noreply.github.com [tool] Don't require a Flutter compile task when staging jniLibs (flutter/flutter#188805)
2026-06-30 jason-simmons@users.noreply.github.com [Impeller] Fix potential overflow when allocating buffers at the next power of two size (flutter/flutter#188742)
2026-06-30 bkonyi@google.com [Framework/Tool] Decouple preview theme imports (flutter/flutter#188176)
2026-06-30 kustermann@google.com Add import of `dart:_js_interop_wasm` in sdk rewriter tool (flutter/flutter#188620)
2026-06-30 15619084+vashworth@users.noreply.github.com Detach LLDB and print stack trace on process stop (flutter/flutter#188576)
2026-06-30 robert.ancell@canonical.com [Linux] Fix FlCompositorOpenGL.pixels comment (flutter/flutter#188754)
2026-06-30 bkonyi@google.com [flutter_tools] Fix crash in flutter create when pubspec.yaml is empty (flutter/flutter#188385)
2026-06-30 engine-flutter-autoroll@skia.org Roll Packages from 656ccaa to 274ed3e (23 revisions) (flutter/flutter#188792)
2026-06-30 jason-simmons@users.noreply.github.com In AndroidImageGenerator, check that the destination pixel buffer has sufficient capacity for the decoded data (flutter/flutter#188752)
2026-06-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#188773)
2026-06-30 bdero@google.com [Impeller] Add a flat VertexAttributeFormat for vertex inputs (flutter/flutter#188684)
2026-06-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#188764)
2026-06-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 0cb483880b6b to e1bdb9ce3327 (2 revisions) (flutter/flutter#188763)
2026-06-29 matt.boetger@gmail.com Handle 'no permissions' adb device state (flutter/flutter#187248)
2026-06-29 30870216+gaaclarke@users.noreply.github.com [windows]: adjusts uniform buffers to hit hlsl optimization (flutter/flutter#188538)
2026-06-29 engine-flutter-autoroll@skia.org Roll Skia from bfb7860cb9c7 to 71947c4110b0 (9 revisions) (flutter/flutter#188747)
2026-06-29 codefu@google.com ci: extract wait-for-engine-build logic into a reusable composite action (flutter/flutter#188748)
2026-06-29 okorohelijah@google.com Provide guided migration logs when iOS app crashes on simulator (flutter/flutter#188736)
2026-06-29 154381524+flutteractionsbot@users.noreply.github.com Revert "[flutter_tools] Track asset transformer dependencies for hot reload" (flutter/flutter#188751)
2026-06-29 34871572+gmackall@users.noreply.github.com Migrate ABI splits to new AGP dsl (flutter/flutter#188369)
2026-06-29 60122246+xiaowei-guan@users.noreply.github.com Add Impeller+OpenGLES startup benchmark for mokey (flutter/flutter#188495)
2026-06-29 louisehsu@google.com Increase macOS minimum supported version from 10.15 to 12 to support Xcode 27  (flutter/flutter#188520)
2026-06-29 30870216+gaaclarke@users.noreply.github.com Moves test ownership validation to flutter/flutter (flutter/flutter#188655)
2026-06-29 angy.avv.94@hotmail.it Add --flavor support for Windows desktop builds (flutter/flutter#187034)
2026-06-29 awolff@google.com Android_hardware_smoke_test: Enable pixel exact local file comparator to read goldens from flutter asset URI (flutter/flutter#188587)
2026-06-29 64674824+yashas-hm@users.noreply.github.com [flutter_tools] Use DeviceHub.app for iOS simulator path on Xcode 27+ (flutter/flutter#187910)
2026-06-29 engine-flutter-autoroll@skia.org Roll Skia from 111e7582d081 to bfb7860cb9c7 (2 revisions) (flutter/flutter#188731)
2026-06-29 jacksongardner@google.com Use `revert` label instead of `revert_wf` (flutter/flutter#188639)
2026-06-29 bkonyi@google.com Properly await Dart Development Service shutdown with timeout (flutter/flutter#188387)
2026-06-29 bkonyi@google.com [flutter_tools] Track asset transformer dependencies for hot reload (flutter/flutter#187947)
2026-06-29 bkonyi@google.com [Tool] Tolerate malformed UTF-8 in process streaming decoders (flutter/flutter#188453)
2026-06-29 nshahan@google.com [flutter_tools] Use new ddc modules in test (flutter/flutter#188240)
2026-06-29 engine-flutter-autoroll@skia.org Roll Packages from c1f7d92 to 656ccaa (12 revisions) (flutter/flutter#188728)
2026-06-29 robert.ancell@canonical.com Remove unused fields (flutter/flutter#188705)
2026-06-29 robert.ancell@canonical.com Clear text input handler widget on view dispose (flutter/flutter#188701)
2026-06-29 robert.ancell@canonical.com Free compositor in view renderer finalize to avoid use-after-free (flutter/flutter#188702)
2026-06-29 robert.ancell@canonical.com [linux] Use GWeakRef in mock signal handler test helper (flutter/flutter#188700)
2026-06-29 Rusino@users.noreply.github.com Fixing few related editing issues with LTR/RTL text (flutter/flutter#188503)
2026-06-29 bdero@google.com [Flutter GPU] Add Texture.fromImage to wrap a ui.Image texture (flutter/flutter#188605)
2026-06-29 bdero@google.com [Flutter GPU] Honor the enable argument in RenderPass.setDepthWriteEnable (flutter/flutter#188715)
2026-06-29 engine-flutter-autoroll@skia.org Roll Skia from ba1942d8c3e1 to 111e7582d081 (1 revision) (flutter/flutter#188721)
2026-06-29 engine-flutter-autoroll@skia.org Roll Skia from 587d8befe1ee to ba1942d8c3e1 (6 revisions) (flutter/flutter#188717)
2026-06-29 mosum@google.com Remove some refs to package:intl (flutter/flutter#188504)
2026-06-29 jhy03261997@gmail.com [VPAT] Update a11y assessment app FAB example to announce value change when it's updated. (flutter/flutter#188466)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants