Skip to content

[material_ui] Remove widgets import in menu_anchor_test.dart #11995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Jun 25, 2026
Merged

[material_ui] Remove widgets import in menu_anchor_test.dart #11995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions ...rily_disabled_tests/menu_anchor_test.dart → ...es/material_ui/test/menu_anchor_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@Skip(
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
)
import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart';
import 'package:material_ui/material_ui.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:leak_tracker/leak_tracker.dart';

@QuncCccccc QuncCccccc Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In flutter/packages, packages/material_ui/pubspec.yaml only has: leak_tracker_flutter_testing: ^3.0.10, there is no leak_tracker, so there is a warning to remove it.

import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
import 'package:material_ui/material_ui.dart';

import '../widgets/semantics_tester.dart';
import 'semantics_tester.dart';

void main() {
late MenuController controller;
Expand Down Expand Up @@ -5091,11 +5087,6 @@ void main() {
controller.close();
await tester.pump();

// Garbage collect. 1 should be enough, but 3 prevents flaky tests.
await tester.runAsync<void>(() async {
await forceGC(fullGcCycles: 3);
});

expect(state.target, isNull);
},
// Skipped on Web: [intended] ForceGC does not work in web and in release mode. See https://api.flutter.dev/flutter/package-leak_tracker_leak_tracker/forceGC.html
Expand Down
Loading