Skip to content

[go_router] Migrate tests away from old handlePlatformMessage #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Mar 30, 2023
Merged

[go_router] Migrate tests away from old handlePlatformMessage #3599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0962080
[go_router] Migrate tests away from old handlePlatformMessage
goderbauer Mar 30, 2023
e2cbd8b
make analyzer happy
goderbauer Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/go_router/example/test/path_and_query_params_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ void main() {
ByteData message = const JSONMethodCodec().encodeMethodCall(
MethodCall('pushRouteInformation', testRouteInformation),
);
await ServicesBinding.instance.defaultBinaryMessenger
await tester.binding.defaultBinaryMessenger
.handlePlatformMessage('flutter/navigation', message, (_) {});

await tester.pumpAndSettle();
Expand All @@ -34,7 +34,7 @@ void main() {
message = const JSONMethodCodec().encodeMethodCall(
MethodCall('pushRouteInformation', testRouteInformation),
);
await ServicesBinding.instance.defaultBinaryMessenger
await tester.binding.defaultBinaryMessenger
.handlePlatformMessage('flutter/navigation', message, (_) {});

await tester.pumpAndSettle();
Expand Down
4 changes: 2 additions & 2 deletions packages/go_router/example/test/redirection_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ void main() {
ByteData message = const JSONMethodCodec().encodeMethodCall(
MethodCall('pushRouteInformation', testRouteInformation),
);
await ServicesBinding.instance.defaultBinaryMessenger
await tester.binding.defaultBinaryMessenger
.handlePlatformMessage('flutter/navigation', message, (_) {});

await tester.pumpAndSettle();
Expand All @@ -36,7 +36,7 @@ void main() {
message = const JSONMethodCodec().encodeMethodCall(
MethodCall('pushRouteInformation', testRouteInformation),
);
await ServicesBinding.instance.defaultBinaryMessenger
await tester.binding.defaultBinaryMessenger
.handlePlatformMessage('flutter/navigation', message, (_) {});

await tester.pumpAndSettle();
Expand Down
12 changes: 6 additions & 6 deletions packages/go_router/test/go_router_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ import 'test_helpers.dart';
const bool enableLogs = false;
final Logger log = Logger('GoRouter tests');

Future<void> sendPlatformUrl(String url) async {
Future<void> sendPlatformUrl(String url, WidgetTester tester) async {
final Map<String, dynamic> testRouteInformation = <String, dynamic>{
'location': url,
};
final ByteData message = const JSONMethodCodec().encodeMethodCall(
MethodCall('pushRouteInformation', testRouteInformation),
);
await ServicesBinding.instance.defaultBinaryMessenger
await tester.binding.defaultBinaryMessenger
.handlePlatformMessage('flutter/navigation', message, (_) {});
}

Expand Down Expand Up @@ -1495,7 +1495,7 @@ void main() {

redirected = false;
// Directly set the url through platform message.
await sendPlatformUrl('/dummy');
await sendPlatformUrl('/dummy', tester);

await tester.pumpAndSettle();
expect(router.location, '/login');
Expand Down Expand Up @@ -1528,7 +1528,7 @@ void main() {

expect(router.location, '/');
// Directly set the url through platform message.
await sendPlatformUrl('/dummy');
await sendPlatformUrl('/dummy', tester);
await tester.pumpAndSettle();
expect(router.location, '/dummy');
});
Expand Down Expand Up @@ -1631,7 +1631,7 @@ void main() {
});
redirected = false;
// Directly set the url through platform message.
await sendPlatformUrl('/dummy');
await sendPlatformUrl('/dummy', tester);

await tester.pumpAndSettle();
expect(router.location, '/login');
Expand Down Expand Up @@ -2024,7 +2024,7 @@ void main() {
final GoRouter router = await createRouter(routes, tester);

// Directly set the url through platform message.
await sendPlatformUrl('/dummy/dummy2');
await sendPlatformUrl('/dummy/dummy2', tester);

await tester.pumpAndSettle();
expect(router.location, '/other');
Expand Down