Skip to content

[google_maps_flutter] Fix incorrect comment: Change "marker" to "polyline" - #7664

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
dhiaCodes:patch-1
Sep 27, 2024
Merged

[google_maps_flutter] Fix incorrect comment: Change "marker" to "polyline"#7664
auto-submit[bot] merged 6 commits into
flutter:mainfrom
dhiaCodes:patch-1

Conversation

@dhiaCodes

@dhiaCodes dhiaCodes commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

This pull request fixes an incorrect comment in the polyline.dart file.

fixes #155379

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla

google-cla Bot commented Sep 18, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Thanks for the contribution!

Which of the linked exemption reasons are you requesting an exemption under?

@dhiaCodes

Copy link
Copy Markdown
Contributor Author

Thanks for the contribution!

Which of the linked exemption reasons are you requesting an exemption under?

Thanks for your feedback! I believe this PR is a small tweak, so I thought it might be exempt from versioning. If that's incorrect, I'd be happy to uncheck the box and make the necessary changes—I'm still learning the process.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

I believe this PR is a small tweak, so I thought it might be exempt from versioning.

The reasons a PR would be exempt are those listed in the linked document.

@dhiaCodes

dhiaCodes commented Sep 19, 2024

Copy link
Copy Markdown
Contributor Author

I believe this PR is a small tweak, so I thought it might be exempt from versioning.

The reasons a PR would be exempt are those listed in the linked document.

I updated the version inside pubspec.yaml to 2.9.3
Would that work?

@dhiaCodes

Copy link
Copy Markdown
Contributor Author

@stuartmorgan, can we merge this PR?

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

@dhiaCodes In order to land, the PR needs passing all CI checks, and then to be reviewed. Please see the Details section of the Linux repo_checks and update the PR accordingly; once it's passing CI I can review it.

@dhiaCodes

Copy link
Copy Markdown
Contributor Author

@stuartmorgan I get it. Now it has passed all CI checks and is ready for your review. thank you

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tarrinneal Could you do the secondary approval on this one?

@tarrinneal tarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2024
@auto-submit
auto-submit Bot merged commit 7f21bb6 into flutter:main Sep 27, 2024
@dhiaCodes
dhiaCodes deleted the patch-1 branch September 27, 2024 23:45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 30, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 30, 2024
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Sep 30, 2024
flutter/packages@0321757...27c9853

2024-09-28 tarrinneal@gmail.com [pigeon] fix int bug (flutter/packages#7725)
2024-09-28 echo.ellet@gmail.com [pigeon] update deprecated command in README of the example (flutter/packages#7709)
2024-09-27 84049068+dhiaCodes@users.noreply.github.com [google_maps_flutter] Fix incorrect comment: Change "marker" to "polyline" (flutter/packages#7664)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Oct 1, 2024
flutter/packages@0321757...27c9853

2024-09-28 tarrinneal@gmail.com [pigeon] fix int bug (flutter/packages#7725)
2024-09-28 echo.ellet@gmail.com [pigeon] update deprecated command in README of the example (flutter/packages#7709)
2024-09-27 84049068+dhiaCodes@users.noreply.github.com [google_maps_flutter] Fix incorrect comment: Change "marker" to "polyline" (flutter/packages#7664)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
iandis pushed a commit to iandis/flutter-packages that referenced this pull request May 23, 2025
…line" (flutter#7664)

*This pull request fixes an incorrect comment in the `polyline.dart` file.*

fixes [#155379
](flutter/flutter#155379)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…line" (flutter#7664)

*This pull request fixes an incorrect comment in the `polyline.dart` file.*

fixes [#155379
](flutter/flutter#155379)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…line" (flutter#7664)

*This pull request fixes an incorrect comment in the `polyline.dart` file.*

fixes [#155379
](flutter/flutter#155379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect comment in polyline.dart: "marker" should be "polyline"

3 participants