Implement retention namespace generation transitions - #78
Draft
flyingrobots wants to merge 50 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Implement the accepted
keep.segment-store/v2retention and one-way migration campaign tracked by #19 without weakening Keep's exact-byte, fail-closed storage law.The affected invariant is that retention authority must be generation-checked, canonical, deterministic, bounded, and durable before any reader or writer may treat a version-2 state as admitted. This branch preserves every version-1 segment, catalog, and publication-head byte.
Plan
Current status
This is an early Draft PR. The format and storage-independent laws are substantially implemented, but the requirements ledger still marks the production filesystem, restart, reader-fence, model, and crash-injection slices as in progress or planned. Version 1 therefore remains the only admitted production store.
The current branch contains 50 commits spanning the #19 campaign. The latest repair separates repository-task root identity observation from the strict production ext4 admission probes. This restores the hosted process-death crash matrix without weakening production admission, and crash-matrix I/O diagnostics now preserve their exact source.
Failure modes
Validation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-featurescargo xtask durability-crash-matrixcargo xtask source-structure-checkcargo check --workspace --all-targets --all-features --target x86_64-unknown-linux-gnuCompatibility, recovery, performance, and security
Alternatives rejected
Open questions
Peer review is most useful on the remaining filesystem publication/restart ordering and the reader-fence aperture before those irreversible protocol slices are implemented.
Closes #19 only when every unchecked Plan item and the colocated requirements ledger are complete.