Skip to content

UIU-3463: Resolve each Promise's resolve in AsyncValidateField to allow saving the user record (follow-up).#3059

Merged
Dmytro-Melnyshyn merged 3 commits into
masterfrom
UIU-3463
Jul 9, 2026
Merged

UIU-3463: Resolve each Promise's resolve in AsyncValidateField to allow saving the user record (follow-up).#3059
Dmytro-Melnyshyn merged 3 commits into
masterfrom
UIU-3463

Conversation

@Dmytro-Melnyshyn

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Purpose

Be able to save a user record after entering a barcode/username (the Save button does nothing).

Approach

The root cause is that not all Promise's resolve were resolved in AsyncValidateField.
The fix is to resolve the previous resolve on each entered character.

Issues

https://folio-org.atlassian.net/browse/UIU-3463
https://folio-org.atlassian.net/browse/UIU-3604

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@Dmytro-Melnyshyn
Dmytro-Melnyshyn requested a review from a team July 9, 2026 08:51
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Jest Unit Test Results

    1 files  ±0    291 suites  +1   5m 51s ⏱️ +18s
1 521 tests +4  1 518 ✅ +4  3 💤 ±0  0 ❌ ±0 
1 557 runs  +4  1 554 ✅ +4  3 💤 ±0  0 ❌ ±0 

Results for commit 3b53aaa. ± Comparison against base commit 4224448.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn
Dmytro-Melnyshyn requested a review from a team July 9, 2026 08:54
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

@Dmytro-Melnyshyn
Dmytro-Melnyshyn merged commit 4987da0 into master Jul 9, 2026
16 checks passed
@Dmytro-Melnyshyn
Dmytro-Melnyshyn deleted the UIU-3463 branch July 9, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants