[FCM-DebtDay] Add support for Ruby 3 and Rails 7 - #1
Merged
Conversation
| hash[key] << convert_to_id(value) | ||
| else | ||
| hash[klass.polymorphic_name] << convert_to_id(value) | ||
| hash[klass(value).polymorphic_name] << convert_to_id(value) |
There was a problem hiding this comment.
The Ruby 3/Rails 7 PR for the original polymorphic_integer_type repo called klass(value) with the safe navigation operator (ex klass(value)&.polymorphic_name), not sure what we risk breaking without it
postfixrevolution
approved these changes
Feb 15, 2023
WilsonMinFong
pushed a commit
that referenced
this pull request
Jun 26, 2025
Ruby 3 and rails 7 support
arman-radicle
added a commit
that referenced
this pull request
Jul 23, 2026
…morphic_name guard + regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original repo of polymorphic_integer_type doesn't appear to be actively maintained any more. There's an open PR to address adding Ruby 3 and Rails 7 support. We decided to fork the original repo so that we can add this support without needing to rely on the original repo or another fork.
Testing
Specs all pass within this repo. We also tested pointing the rma repo to this branch and verified that the deprecation warning is gone and that the behavior added by polymorphic_integer_type still works.