fix: hardening — NULL check, max_inode bound, stopAccessing leak - #1
Open
kaffeindecaf wants to merge 1 commit into
Open
fix: hardening — NULL check, max_inode bound, stopAccessing leak#1kaffeindecaf wants to merge 1 commit into
kaffeindecaf wants to merge 1 commit into
Conversation
- bad_query_list: add NULL path check and clamp max_inode to UINT32_MAX - ContentView.swift: add stopAccessingSecurityScopedResource via defer (was leaking kernel security-scoped resource)
sousicky
approved these changes
Aug 11, 2026
Owner
|
Some of these will likely be resolved in a future revision (without 100% vibe-reviewing the code to find things I should fix), thanks I guess, though. |
|
@forcequitOS I have compile this source and run success. Is there any chance not ask open develp mode? |
Author
Alright!(sorry for sloppifying everything with deepseek i didnt even know it made a PR😭😭) |
|
hi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3 hardening fixes from W0lfSword deep audit.
Changes
pathparameter inbad_query_list()(prevent crash)max_inodeto UINT32_MAX to prevent infinite loop if caller passes INT64_MAXstopAccessingSecurityScopedResource()viadefer(was leaking kernel security-scoped resource handle)Testing
bad_query_list(NULL, 0)returns NULL instead of crashingbad_query_list(path, INT64_MAX)does not hang