The tracks say what they are: motiongrams from the motion frame, videograms from the picture - #385
Merged
Merged
Conversation
…ograms from the picture `extract_tracks` averaged the motion frame along each axis and stored the result under the videogram name, so a "videogram" of a concert was black with lines at the cuts (#383). The arrays are now `motiongram_v.u1` / `motiongram_h.u1`, and one extra ffmpeg filter graph writes true videograms beside them, trimmed so that column j lines up with motion frame j. `read_columns`, `build_pyramid` and `render_timeline` take both names; a folder written before the rename serves its motion means under `motiongram_*` and refuses `videogram_*` with a message instead of returning motion data. Also `_mocap.read_c3d` imported `MgError` from the wrong module, which failed mypy on master. Fixes #383 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcjBSXbXjqdj1tmYHoLiKd
…usal Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcjBSXbXjqdj1tmYHoLiKd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_tracks/extract_tracks_parallelnow writemotiongram_v.u1/motiongram_h.u1(means of the motion frame, what the oldvideogram_*files held) and, by default, truevideogram_v.u1/videogram_h.u1from one extra ffmpeg filter graph (extract_videograms), trimmed so column j lines up with motion frame j.videograms=Falseskips the extra pass.read_columns,build_pyramidandrender_timelineaccept both names (span by axis suffix). A pre-rename folder serves its motion means undermotiongram_*and refusesvideogram_*with a message._mocap.read_c3dimportedMgErrorfrom_utils; it lives in_exceptions.Test plan
tests/test_true_videograms.py: a static bright bar shows in the videogram and not in the motiongram; a moving square shows in the motiongram; both names read throughread_columnsand build their own pyramid; a legacy folder serves motion means under the new name and refuses the old one.tests/test_tracks.py,tests/test_pyramid_on_demand.py,tests/test_tracks_completeness.pypass (16 total with the new file)._tracks,_timeline,_mocapwith the project configuration.🤖 Generated with Claude Code
https://claude.ai/code/session_01PcjBSXbXjqdj1tmYHoLiKd