Conversation
Horofic
requested changes
Sep 26, 2025
| @@ -1,11 +1,13 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| from dissect.database.bsd.db import DB | |||
Member
There was a problem hiding this comment.
Hmm, in hindsight. Maybe you want to rename DB to BerkleyDB or something along those lines? For instance, from dissect.database import DB feels a bit ambiguous now.
Member
Author
There was a problem hiding this comment.
I thought about that too, but it's just a convenience import. The recommended import path is either from dissect.database.bsd.db import DB or from dissect.database.bsd import DB.
I don't have super strong opinion either way, but DB is (sadly) more in line with the Berkeley DB nomenclature.
Horofic
approved these changes
Sep 26, 2025
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
twiggler
pushed a commit
to twiggler/dissect-monorepo-test
that referenced
this pull request
May 26, 2026
twiggler
pushed a commit
to twiggler/dissect-monorepo-test
that referenced
this pull request
Jun 4, 2026
twiggler
pushed a commit
to twiggler/dissect-monorepo-test
that referenced
this pull request
Jun 5, 2026
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also changed and fixed a few things:
esedbtoeseESE