Add bbolt implementation - #63
Conversation
| for inode in page.inodes(): | ||
| if inode.key == part: | ||
| if inode.flags == 1: |
There was a problem hiding this comment.
So I did not read up on any implementation details, but can you tell me if this is "the official" way of doing things, or just a simpler "naive" way? E.g., is there an opportunity for a speedup in the future by doing a binary search?
Just asking so that we can make an issue for that, not necessarily for implementing right away.
There was a problem hiding this comment.
Yes this can definitely be implemented more efficiently. I think the linked resources should point in the right direction.
There was a problem hiding this comment.
Can you make a issue for that after this is merged? Just to track that as a possible future improvement.
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 152 155 +3
Lines 4716 4844 +128
======================================
- Misses 4716 4844 +128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance🎉 Hooray!
|
Fixes #62.