Skip to content

Add bbolt implementation - #63

Merged
Schamper merged 4 commits into
fox-it:mainfrom
JSCU-CNI:bbolt
Aug 27, 2026
Merged

Add bbolt implementation#63
Schamper merged 4 commits into
fox-it:mainfrom
JSCU-CNI:bbolt

Conversation

@JSCU-CNI

Copy link
Copy Markdown
Contributor

Fixes #62.

Comment thread dissect/database/bbolt/bbolt.py Outdated
Comment thread dissect/database/bbolt/bbolt.py Outdated
Comment on lines +54 to +56
for inode in page.inodes():
if inode.key == part:
if inode.flags == 1:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I did not read up on any implementation details, but can you tell me if this is "the official" way of doing things, or just a simpler "naive" way? E.g., is there an opportunity for a speedup in the future by doing a binary search?

Just asking so that we can make an issue for that, not necessarily for implementing right away.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this can definitely be implemented more efficiently. I think the linked resources should point in the right direction.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a issue for that after this is merged? Just to track that as a possible future improvement.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue here #64

Comment thread dissect/database/bbolt/bbolt.py Outdated
JSCU-CNI and others added 3 commits August 27, 2026 17:13
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@JSCU-CNI
JSCU-CNI requested a review from Schamper August 27, 2026 15:38
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 128 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (62f6301) to head (4693c01).

Files with missing lines Patch % Lines
dissect/database/bbolt/bbolt.py 0.00% 117 Missing ⚠️
dissect/database/bbolt/c_bbolt.py 0.00% 6 Missing ⚠️
dissect/database/bbolt/__init__.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main     #63    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        152     155     +3     
  Lines       4716    4844   +128     
======================================
- Misses      4716    4844   +128     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Aug 27, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

🎉 Hooray! pytest-codspeed just leveled up to 5.0.3!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

✅ 6 untouched benchmarks


Comparing JSCU-CNI:bbolt (4693c01) with main (62f6301)

Open in CodSpeed

@Schamper
Schamper merged commit bafd33c into fox-it:main Aug 27, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement BoltDB

2 participants