Allow per-instance filesystem protocols - #2117
Open
be-student wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1800
AbstractFileSystem.protocolis currently declared as aClassVar, so type checkers reject filesystem adapters that choose their protocol from constructor state. This removes theClassVarrestriction while preserving the existing string-or-tuple type and class default.Concrete implementations with a fixed protocol can continue declaring their own
ClassVar. The changelog now documents support for per-instance protocol selection.Validation:
Attribute "protocol" cannot be assigned through a class instance because it is a ClassVarand passes afterward with 0 errors.fsspec/tests/test_spec.pyportable tests: 186 passed, 10 skipped, 1 xfailed. The 52 excluded Bash-reference cases require GNUstat -cand fail unchanged on macOS.git diff --checkpass.