Skip to content

chore: Update documentation build to use poetry / python 3.10 #36

Merged
torsdag merged 1 commit into
mainfrom
backlog/readthedocs-python-version
Mar 18, 2024
Merged

chore: Update documentation build to use poetry / python 3.10 #36
torsdag merged 1 commit into
mainfrom
backlog/readthedocs-python-version

Conversation

@torsdag

@torsdag torsdag commented Mar 18, 2024

Copy link
Copy Markdown
Contributor

Resolves

  • I have added automatic tests where applicable.
  • The PR contains a description of what has been changed.
  • The description contains manual test instructions.
  • The PR contains updates to the release notes.
  • I have verified that the documentation is still up to date.

Changes

  • use poetry for dependency resolution when building documentation.
  • use python 3.10 when building documentation.
  • make sphinx and sphinx_rtd_theme development dependencies.

Test

https://ftrack-python-api.readthedocs.io/en/backlog-readthedocs-python-version/

@torsdag torsdag requested a review from a team March 18, 2024 10:27

@octavian-ionescu octavian-ionescu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread readthedocs.yaml
os: ubuntu-22.04
tools:
python: "3.7"
python: "3.10"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we only go up to 3.10 and not 3.12?

@torsdag torsdag merged commit 84019bc into main Mar 18, 2024
@torsdag torsdag deleted the backlog/readthedocs-python-version branch March 18, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants