Add scrubber bip - #12
Merged
Merged
Conversation
|
Maybe put this in a "BIPs" folder? Since we also have concurrent psbt bip that would be good put in same folder. |
Contributor
i suggest |
nothingmuch
reviewed
Aug 12, 2026
bc1cindy
reviewed
Aug 12, 2026
bc1cindy
left a comment
Contributor
There was a problem hiding this comment.
concecpt ACK, great work!
arminsabouri
force-pushed
the
psbt-scruber
branch
from
August 31, 2026 19:11
b40b036 to
a0de778
Compare
yuval-block
approved these changes
Sep 10, 2026
yuval-block
left a comment
Collaborator
There was a problem hiding this comment.
nitpicky comment not worth addressing, only if it bothers you
|
|
||
| ### Sorting | ||
|
|
||
| If signers use different libraries with different serialization implementations, an untrusting party can identify the signer by the order in which they encode fields. To prevent this, the scrubber must sort each map lexigraphically by `key` after it removes sensitive fields. |
Collaborator
There was a problem hiding this comment.
nit: doesn't matter if it's before or after, same effect and implementors may choose whichever
Collaborator
Author
There was a problem hiding this comment.
Doesn't really bother me. Can follow up with an edit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.