Skip to content

Update translate_from signature + handling different from_translators  #150

Description

@korikuzma

The dispatch table approach is pretty clean when each translator has the same arguments, but if we need different params for different translators, I think we probably have to call them within some if/then blocks. A little inelegant but IMO cleaner than passing a bunch of unused arguments to every other function.

Originally posted by @jsstevenson in #148 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions