Input type issues in using `Translator` to translate from VRS

[jsstevenson]

This code here tries to subscript into models, which is a module, on line 132. This obviously leads to an error:

vrs-python/src/ga4gh/vrs/extras/translator.py

Lines 125 to 135 in f38cbca

	def _from_vrs(self, var):
	"""Convert from dict representation of VRS JSON to VRS object"""
	if not isinstance(var, Mapping):
	return None
	if "type" not in var:
	return None
	try:
	model = models[var["type"]]
	except KeyError:
	return None
	return model(**var)

I think a bigger problem is inconsistency about expected inputs. The other translators take variant expressions as strings, but translating from VRS seems to try to handle either dicts or Pydantic objects (realistically, probably actually PythonJsonSchemaObjects, not Pydantic). I think it'd be better to maybe expect input to be a JSON object serialized into a string, just to remain consistent and avoid these kinds of issues.

[Kirti-Pant]

issue#489
Here is the corrected code snippet you can use:

try:
model = getattr(models, var["type"])
except AttributeError:
return None

[jossephlee82-art]

I also agree the broader concern is input consistency across translators. If other morse code translator accept string-based variant expressions, handling raw dicts or object types here introduces unnecessary ambiguity. Standardizing around serialized JSON strings could simplify validation and reduce edge-case errors like this.