feat (theme-compatibility): features can now inherit theme styles. - #3052
Closed
prconcepcion wants to merge 14 commits into
Closed
feat (theme-compatibility): features can now inherit theme styles.#3052prconcepcion wants to merge 14 commits into
prconcepcion wants to merge 14 commits into
Conversation
🤖 Pull request artifacts
|
|
Size Change: +1.04 kB (0%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
bfintal
reviewed
Feb 15, 2024
bfintal
left a comment
Contributor
There was a problem hiding this comment.
Since we now have 2 inheritance options, please create 2 options instead of 1: 1 for inheriting button styles and 1 for inheriting image captions
For the image captions, you'll also need to add the following changes:
- add the class
wp-block-imageto the image - out figcaption margins are currently overriding the inherited figcation styles, use
.stk-block-image .stk-img-figcaption:not(.wp-element-caption)on our figcaption css to prevent overriding.
bfintal
reviewed
Feb 15, 2024
| return ( | ||
| <Link | ||
| className={ classnames( [ className, getButtonClasses( attributes ) ] ) } | ||
| className={ classnames( [ className, getButtonClasses( attributes ), settings.stackable_inherit_styles_from_theme && 'wp-element-button' ] ) } |
Contributor
There was a problem hiding this comment.
This looks hard to read, split off to:
const linkClassnames = classnames( [
className,
getButtonClasses( attributes ),
{ 'wp-element-button': settings.stackable_inherit_styles_from_theme }
] )
bfintal
reviewed
Feb 15, 2024
bfintal
reviewed
Feb 15, 2024
bfintal
reviewed
Feb 15, 2024
9 tasks
|
Added comment from Discord (02/16/2024): |
Contributor
|
Closing as superseded by #3490 (theme.json block style inheritance). Buttons now inherit styles from block themes via the existing “Inherit Block Styles from theme.json” setting, so this older Deleting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3035
fixes #2354
fixes #3057
fixes #3150