Repository navigation
feat: Windows DPAPI cookie decryption + v20 fallback - #392
Closed
getabsolutehealth wants to merge 4 commits into
Closed
getabsolutehealth wants to merge 4 commits into
getabsolutehealth wants to merge 4 commits into
Conversation
Add cross-platform cookie extraction for Windows Chromium browsers: - Platform-aware path resolution (LOCALAPPDATA + windowsDataDir) - DPAPI key extraction via PowerShell for v10 cookies - AES-256-GCM decryption (Windows) alongside existing AES-128-CBC (macOS) - Multi-profile detection (Default + Profile N directories) - Network/Cookies path support for newer Chromium - SQLITE_CANTOPEN handling for Windows exclusive file locks - Informative v20 App-Bound Encryption error message - Short buffer protection in decryptWindows - Dangling timeout fix in DPAPI PowerShell call - 5 new AES-256-GCM round-trip and tamper-detection tests
When Windows v20 App-Bound Encryption prevents direct decryption: - New /cookie-picker/import-raw POST endpoint accepts pre-decrypted cookies - Picker UI shows console-script fallback with copy button - Script captures document.cookie and sends to gstack's import-raw endpoint - Domain validation skips cookies without a domain
- Windows: cmd /c start '' <url> (with empty title arg) - macOS: open <url>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@16francej Please close this PR. Windows cookie decryption and the Chrome v20 fallback already shipped in the safer #892/#1028 implementation. This branch is now redundant. |
|
Heads up: this is superseded. #2964 shipped Windows DPAPI cookie decryption with a deliberate no-TCP-fallback / sign-in-manually policy for App-Bound (v20) cookies, and #2987 builds on that (Opera/Opera GX, a Windows v10 hash-prefix fix, actionable recovery messages). I'll close this after #2987 merges. Thanks for the early work on this path. |
|
Closing now that #2987 has merged (v1.91.4.0), which supersedes this. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/cookie-picker/import-rawendpoint — accepts pre-decrypted cookies for the fallback flow.cmd /c starttitle arg, dangling setTimeout, short buffer protection, SQLITE_CANTOPEN handling, empty domain filter.Test Coverage
23 tests pass (0 fail). 5 new AES-256-GCM tests: round-trip, special chars, empty value, tampered auth tag, tampered ciphertext.
Pre-Landing Review
1 issue found, auto-fixed (empty domain cookies in import-raw endpoint). Adversarial review found 5 additional fixable issues — all auto-fixed.
Test plan
🤖 Generated with Claude Code