Conversation
8 mktemp calls in review.ts and design.ts create temp files in /tmp/ for Codex prompt and stderr capture, but never clean them up. Over time these accumulate (~5KB each, per /autoplan or /review run). Fix: add rm -f after each cat of the temp file. Files cleaned up immediately after reading, even on error (|| true).
8 tasks done
Collaborator
|
Closing — main already ships an equivalent fix for this. Thanks for the report and patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mktempcalls inreview.tsanddesign.tscreate temp files for Codex prompt/stderr/tmp/on every/autoplan,/review,/shiprunrm -fafter eachcatof the temp file2 files, 8 cleanup lines added
scripts/resolvers/review.ts— 5 temp filesscripts/resolvers/design.ts— 3 temp filesTest plan