fix: make /ship reruns resume safely - #684
Closed
AliFozooni wants to merge 2 commits into
Closed
AliFozooni wants to merge 2 commits into
AliFozooni wants to merge 2 commits into
Conversation
8 tasks
Contributor
|
@16francej Please close this PR. Safe resume behavior for repeated ship runs already shipped in #693 and was hardened further on main. This older branch relies on fragile commit-message guesses and should not be merged. |
|
Closing as superseded by #693 and the current shipping workflow, most recently clarified in merged #2970. Current main classifies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/shipversion bump so a failed PR-creation step resumes instead of double-bumpingVERSIONProblem
A partial failure between push and PR creation can currently leave
/shipin a state where rerunning the workflow bumpsVERSIONagain and duplicates the topCHANGELOGentry.Testing
git diff --checknodeverification of the new resume-safety strings inship/SKILL.md,ship/SKILL.md.tmpl, andtest/gen-skill-docs.test.tsFixes #649