Add Vara mainnet faucet MVP - #2595
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
| children: ReactNode; | ||
| }; | ||
|
|
||
| function VerificationOverlay({ isVisible, children }: VerificationOverlayProps) { |
There was a problem hiding this comment.
VerificationOverlay is copied from GetTestBalance instead of being extracted to a shared faucet helper. Please dedupe rather than maintaining two near-identical portal overlays and importing styles from get-test-balance.module.scss.
You can create separate component in idea\gear\frontend\src\features\balance\ui\verification-overlay
| parameters?: object; | ||
| }; | ||
|
|
||
| const fetchMainnetJson = async <T>( |
There was a problem hiding this comment.
fetchMainnetJson largely duplicates fetchWithGuard, mainly to pass custom headers (Idempotency-Key). Prefer extending fetchWithGuard (or a thin wrapper) so error parsing stays in one place.
| const activePayoutClaims = claims.filter(({ status }) => activePayoutStatuses.includes(status)); | ||
| const activePayoutClaims1h = activePayoutClaims.filter( | ||
| ({ payoutStartedAt }) => payoutStartedAt && payoutStartedAt >= hourAgo, | ||
| ); | ||
| const activePayoutClaims24h = activePayoutClaims.filter( | ||
| ({ payoutStartedAt }) => payoutStartedAt && payoutStartedAt >= dayAgo, | ||
| ); |
There was a problem hiding this comment.
I believe it all can be just the part of the db query
Summary
Adds a guarded Vara mainnet faucet flow to IDEA:
transferKeepAlivepayouts and moves uncertain outcomes to reconciliationFlow
Validation
yarn build:gear-idea-faucetyarn workspace gear-idea-frontend buildyarn workspace gear-idea-faucet test:coverage(100%)git diff --check