Repository navigation
Cloud instance name - #27
Merged
Merged
Conversation
* Instance names allow leading digits * Cloud instance name max length: 62 * Dashes are allowed, except for consecutive ones like --
fantix
added a commit
to geldata/gel-cli
that referenced
this pull request
Mar 20, 2023
* Disallow underscores * Disallow consecutive dashes in org slug * Limit total length to 42 * Allow single dashes in instance name * Allow leading digits in instance name Also widen local instance name policy: * Allow leading digits * Allow single dashes Depends on edgedb/edbedb-rust#226, geldata/shared-client-testcases#27
fantix
added a commit
to geldata/gel-cli
that referenced
this pull request
Mar 20, 2023
* Disallow underscores * Disallow consecutive dashes in org slug * Limit total length to 42 * Allow single dashes in instance name * Allow leading digits in instance name Also widen local instance name policy: * Allow leading digits * Allow single dashes Depends on geldata/gel-rust#226, geldata/shared-client-testcases#27
fantix
added a commit
to geldata/gel-cli
that referenced
this pull request
Mar 22, 2023
* Disallow underscores * Disallow consecutive dashes in org slug * Limit total length to 62 * Allow single dashes in instance name * Allow leading digits in instance name Also widen local instance name policy: * Allow leading digits * Allow single dashes Depends on geldata/gel-rust#226, geldata/shared-client-testcases#27
elprans
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also widen local instance name policy:
Redo reverted #25 after banning underscores