fix(contracts)!: require consensus acceptance for success, not just the leader's execution result#346
Merged
Merged
Conversation
…eader execution result
- assertSuccessfulExecution now requires status ∈ {ACCEPTED, FINALIZED} via the
SDK's isSuccessful in addition to FINISHED_WITH_RETURN: txExecutionResult is
the LEADER's result and exists even on UNDETERMINED — previously an
undetermined deploy printed 'deployed successfully' with an address that
would never materialize
- failure messages now name both the consensus outcome and the leader result
('decided as UNDETERMINED (no validator majority); leader execution result:
FINISHED_WITH_RETURN')
- map VoteType 3 (TIMEOUT) / 4 (NONDET_DISAGREE) with real diagnoses instead of
'did not expose an execution result'
- deploy/write use waitUntil: 'decided' (new SDK API) and report the reached
consensus status; explicit fee deposits are echoed before sending
- callKey derivation deduplicated: import from genlayer-js (incl. new
DEPLOY_CALL_KEY for deploy-targeted Mode-2 allocations)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
npm 1.1.8 lacks the new fee APIs (isSuccessful, DEPLOY_CALL_KEY, waitUntil), so CI cannot build against it. github:genlayerlabs/genlayer-js#feat/ v06-fee-estimation-rework builds via the SDK's new prepare script (verified: fresh install produces dist + exports). Re-pin to the npm semver once genlayer-js v2 ships (release-sequencing item).
Push trigger was pinned to v0.39 — merges to v0.40-dev/v0.40 got no post-merge CI.
The OIDC upload fails on ubuntu/windows independent of this PR (#345 merged with identical failures); tests/build stay blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #345 closing the remaining 'accepted ≠ executed' gap one level up (designer walkthrough, 2026-06-09).
txExecutionResultis the leader's result, written at reveal even when the round ends UNDETERMINED — so the existing check could print 'deployed successfully' with an address that never materializes. Success now also requires status ∈ {ACCEPTED, FINALIZED} (via genlayer-jsisSuccessful); failures name both the consensus outcome and the leader result.waitUntil: 'decided'API; explicit fee deposits echoed before sending; reached status reported after success.DEPLOY_CALL_KEY), removing a byte-for-byte copy that would silently drift.Depends on genlayerlabs/genlayer-js#187 (waitUntil/isSuccessful APIs). 530 tests green incl. new negative coverage (UNDETERMINED, CANCELED, VoteType 3/4, Studio-shape).