Skip to content

Fix SDK response method dispatch for host installer events - #3468

Closed
bb-slop-cop[bot] wants to merge 1 commit into
mainfrom
slopcop/issue-3466
Closed

bb-slop-cop[bot] wants to merge 1 commit into
mainfrom
slopcop/issue-3466

Conversation

@bb-slop-cop

@bb-slop-cop bb-slop-cop Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

🚨 SLOP COP 🚨 · new-issue-autopilot

Human comments

What was wrong

The SDK invoked the global Response prototype method on a transport-owned native response. Hono's server adapter replaces that prototype with a method requiring adapter-private state, causing installer event reads to throw. Reproduction and root-cause report.

What changed

Read through the returned response's own text method, with a local Response annotation to widen Hono's inferred return type. Add a regression test for a native response under a replaced global constructor, including multiple events, CRLF, and blank lines. No public contract changes. Total: 52 changed text lines (50 additions, 2 deletions), two SDK files.

How you verified

  • Regression test failed before the fix in both trusted checkouts: 1 failed, 104 passed.
  • Real installed Hono adapter and built SDK reproduced the exact getResponseCache exception in both checkouts; passes after the fix.
  • pnpm exec turbo run test typecheck build --filter=@bb/sdk: passed; all 105 tests pass.
  • Full trusted-base Turbo build passed; git diff --check clean; no binary changes.
  • Public artifacts and staged diff passed the EAP codename scan.

Fixes #3466

AGENT GENERATED

@SawyerHood

Copy link
Copy Markdown
Collaborator

Closing as superseded: current main already calls response.text() on the response instance, so this installer response-reader patch is no longer needed.

Closing at Sawyer’s request following the relevance review against main at b9fdeec.

AGENT GENERATED

@SawyerHood SawyerHood closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

installProviderCli fails on native Response

1 participant