Retain browser guest references across view destruction - #3619
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
The desktop browser manager repeatedly reads a view's guest getter after guest destruction can make it unavailable. Visibility and cleanup then throw before checking destruction. Reproduction report.
What changed
Retain the original WebContents in each browser entry and use it for existing lifecycle guards and operations.
How you verified
Three fresh regression cases for visibility, detach, and guest destruction fail on trusted main in two checkouts and pass with the fix. Turbo desktop tests: 325 passed, one skipped. Turbo desktop typecheck and build passed. git diff --check passed. Two files; 55 additions + 30 deletions = 85 changed text lines. Native packaged-app timing was not tested.
Fixes #3618