Guard absent preference entries during client synchronization - #3630
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
Preference synchronization dereferenced absent list entries during reconciliation, write preparation, and acknowledged-write cache merging. An incomplete response could throw instead of retaining local state. Verified reproduction report.
What changed
Guard absent entries during reconciliation and writes, preserving local values without inventing a server revision. Allow an acknowledged write to fill an absent cache entry while retaining newer-revision protection. Changes stay within client preference synchronization: 67 changed text lines (66 additions, 1 deletion), two files.
How you verified
Three authored regressions failed against unchanged origin/main in two clean checkouts; all 22 focused tests passed after the fix.
pnpm exec turbo run test typecheck --filter=@bb/apppassed: 528 test files, 4,599 tests passed, three skipped, and both app TypeScript programs passed.git diff --checkpassed. No live desktop verification is claimed.Fixes #3629