Add macOS Helium browser cookie import - #3900
Merged
Merged
Conversation
manjoot
marked this pull request as ready for review
September 18, 2026 09:40
SawyerHood
force-pushed
the
feat/helium-cookie-import
branch
from
September 18, 2026 21:57
ff8b02e to
ac1eb84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Helium on macOS was missing from the browser registry and shared source-ID schema, so BB's existing cookie importer could not discover or import its profiles.
What changed
Register Helium with its profile directory, process/app name and Keychain identity. The existing settings picker, Chromium reader, SDK and CLI handle the import. Support is macOS-only and remains a one-time copy.
Add
heliumto the shared source schema and bumpHOST_DAEMON_PROTOCOL_VERSIONfrom 214 to 215: the old schema rejects the new ID in both requests and discovered-source results. Also bump the plugin SDK from 0.4.103 to 0.4.104 using the repository script. The generated SDK declarations include the source IDs, so adding Helium changes its published types. Update the browser guide and CLI skill.How you verified
After rebasing onto current main: 24 desktop/broker tests and 42 contract tests pass on Node 22.19.0, along with desktop, contract, and SDK typechecks. The protocol-version assertion now expects 215.
Two regression tests cover importing a selected non-default profile with Helium's Keychain identity and recognising its profile lock. They use real SQLite fixtures with fake OS and Electron calls. Both fail without the Helium registry entry. Five deliberate faults in profile selection, path, Keychain service/account and process name fail the relevant assertions.
On Node 22.19.0: 24 desktop/broker, 42 contract, 12 settings, 3 CLI and 1 SDK-version tests pass. Desktop/contract/SDK typechecks, desktop/SDK builds, formatting, lint, whitespace and the SDK npm version guard pass. Existing build warnings remain.
The contributor tested Helium 0.17.0.1 on macOS, completed the real Keychain prompt and imported 1,446 cookies with 299 skipped. Graphite opened signed in. The contributor also reports testing restart persistence in add helium on macOS to the browser cookie importer #3841; the automated tests do not establish that.
Fixes #3841