Move the desktop Server menu under bb → Desktop Settings - #4274
Merged
ymichael merged 1 commit intoSep 24, 2026
Merged
Conversation
Window → Server stays as an alias for the same submenu. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ymichael
deleted the
bb/test-desktop-settings-server-menu-on-m5-thr_apek8qrctk
branch
September 24, 2026 18:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The desktop app's Server switcher (saved servers, Add Server…, Set Server URL…) was only in Window → Server. That's an odd place for app-level configuration, and people looking in the bb app menu next to Settings didn't find it.
What changed
apps/desktop/src/menu.ts: the bb app menu gets a Desktop Settings submenu (after Settings…) containing the Server submenu. Window → Server stays as an alias built from the samecreateServerMenuItems(args). Each copy has its own menu item ID (bb-desktop-settings-server-menu,bb-server-menu), andinstallApplicationMenuattaches themenu-will-showrefresh hook to both, so the server list stays current whichever copy is opened.apps/desktop/test/menu.test.ts: a new test checks that Desktop Settings → Server shows the same items as Window → Server, and that selecting a server and Add Server… from the new location call the right handlers.apps/desktop/README.md: the Saved servers section now points to the new location and mentions the Window alias.No wire, CLI, or protocol changes.
How you verified
pnpm exec turbo run test typecheck --filter=@bb/desktop: typecheck passes and 435 tests pass. In that full parallel runtest/preload-build.test.tsfailed once. It passes on its own (vitest run test/preload-build.test.ts test/menu.test.ts: 9/9) and doesn't touch the menu code.🤖 Generated with Claude Code