Cache desktop server renderers - #618
Merged
SawyerHood merged 1 commit intoJul 11, 2026
Merged
Conversation
SawyerHood
added a commit
that referenced
this pull request
Jul 12, 2026
…628) ## Summary - remove the desktop multi-server feature now that multi-machine covers it: ServerRail sidebar switcher, Settings › Servers, server tiles, the `bbDesktop.servers` preload API/IPC, the multi-entry `servers.json` registry, per-window active-server state, the per-server renderer view cache (reverts the #618 rescoping of browser views/IPC/reload shortcuts), status/attention polling, and the `autoConnectToLocalServer` setting - server targeting now lives entirely in the native **Window ▸ Server** menu: "This Mac", the bb Connect account servers (synced main-process-side from the local server's connect plugin, authenticated with the existing Connect session-cookie handshake), and an optional custom URL entered through a native "Set Server URL…" dialog - the target is global (switching reloads all windows), persisted to `server-target.json`; the local runtime always starts, with popout/system-config sync/auto-update pinned to it ## Test plan - `pnpm exec turbo run typecheck` (whole workspace, 45/45) - `pnpm exec turbo run test --filter=@bb/app --force` (1379 tests) - `pnpm exec turbo run typecheck test --filter=@bb/desktop --force` (196 tests, incl. new server-target and reworked connect-sync coverage) - `pnpm run package && pnpm run smoke:packaged` in `apps/desktop` (packaged app boots, preload bridge answers) ## Risk - old `servers.json` entries are not migrated; previously added manual/connect servers reset to "This Mac" and can be re-picked from the menu - entering a custom URL no longer probes reachability; an unreachable server shows a load error and you switch back via the menu - the menu-open freshness trigger for the Connect list is best-effort (`menu-will-show`); the list also refreshes on runtime start and every 10 minutes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm exec turbo run typecheck test --filter=@bb/app --filter=@bb/desktop --forcepnpm exec turbo run build --filter=@bb/desktoppnpm exec turbo run smoke:packaged --filter=@bb/desktop --forceRisk
Cached renderers intentionally retain their server connection and state until the server is removed or the desktop window closes.