Skip to content

chore(deps): bump typescript from 5.9.3 to 6.0.3 - #57

Open
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/typescript-6.0.3
Open

chore(deps): bump typescript from 5.9.3 to 6.0.3#57
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/typescript-6.0.3

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 8, 2026

Copy link
Copy Markdown
Contributor

Bumps typescript from 5.9.3 to 6.0.3.

Release notes

Sourced from typescript's releases.

TypeScript 6.0.3

For release notes, check out the release announcement blog post.

Downloads are available on:

TypeScript 6.0

For release notes, check out the release announcement blog post.

Downloads are available on:

TypeScript 6.0 Beta

For release notes, check out the release announcement.

Downloads are available on:

Commits
  • 050880c Bump version to 6.0.3 and LKG
  • eeae9dd 🤖 Pick PR #63401 (Also check package name validity in...) into release-6.0 (#...
  • ad1c695 🤖 Pick PR #63368 (Harden ATA package name filtering) into release-6.0 (#63372)
  • 0725fb4 🤖 Pick PR #63310 (Mark class property initializers as...) into release-6.0 (#...
  • 607a22a Bump version to 6.0.2 and LKG
  • 9e72ab7 🤖 Pick PR #63239 (Fix missing lib files in reused pro...) into release-6.0 (#...
  • 35ff23d 🤖 Pick PR #63163 (Port anyFunctionType subtype fix an...) into release-6.0 (#...
  • e175b69 Bump version to 6.0.1-rc and LKG
  • af4caac Update LKG
  • 8efd7e8 Merge remote-tracking branch 'origin/main' into release-6.0
  • Additional commits viewable in compare view

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jun 8, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/typescript-6.0.3 branch from b0c92c9 to 4a56431 Compare June 8, 2026 09:44
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/typescript-6.0.3 branch 3 times, most recently from 128c86a to 88d2978 Compare June 20, 2026 03:18
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.3 to 6.0.3.
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.9.3...v6.0.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-version: 6.0.3
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/typescript-6.0.3 branch from 88d2978 to 3c31732 Compare June 22, 2026 09:32

get6 commented Jun 22, 2026

Copy link
Copy Markdown
Owner

로컬 PR 검토 결과, 현재 head는 merge-ready가 아닙니다.

변경 요약

  • typescript devDependency가 5.9.3에서 6.0.3으로 올라갔습니다.
  • 변경 파일은 package.json, pnpm-lock.yaml 2개입니다.

로컬 검증

  • pnpm install --frozen-lockfile: 통과. lockfile resolution 변경 없음.
  • git diff --check origin/main...HEAD: 통과.
  • pnpm lint: 통과(exit 0). 기존 @next/next/no-img-element warning 5건만 확인됨.
  • pnpm build: 실패. prebuildts-node scripts/copy-pretendard.ts 단계에서 fs, path, __dirname, process 등 Node 타입/global을 찾지 못해 TSError로 종료됨.

CI / GitHub AI review

  • Dependabot auto-merge / automerge: success.
  • Claude Code Review / review: skipped. Dependabot PR에서 GitHub-hosted AI review가 실행되지 않아 로컬 리뷰로 대체했습니다.

남은 리스크

  • TypeScript 6 환경에서 ts-node로 실행되는 build script가 현재 tsconfig의 Node 타입 해석과 맞지 않습니다.
  • build가 prebuild에서 멈추므로 현재 상태로는 정적 사이트 build/export 검증이 완료되지 않았습니다.

다음 gate

  • scripts/copy-pretendard.ts 또는 tsconfig/ts-node 설정을 TypeScript 6에서 build 가능하도록 수정한 뒤 pnpm install --frozen-lockfile, pnpm lint, pnpm build, git diff --check를 다시 통과시켜야 합니다.

자동화 메모

marker: pr-summary-comment
dedupe: pr:#57:head:3c3173256988281ed0d8fa703e36c81361e391b7:stage:local-independent-review-done

@claude

claude Bot commented Jun 22, 2026

Copy link
Copy Markdown

Claude finished @get6's task in 1m 47s —— View job


PR Review: TypeScript 5.9.3 → 6.0.3

  • Gather context and read changed files
  • Verify tsconfig.json fix for Node types
  • Analyze build compatibility and ts-node behavior
  • Provide full review findings

Summary

This PR has 2 commits: the dependabot dependency bump + a follow-up fix (c50df77 fix: add Node types for ts-node scripts) that adds "types": ["node"] to the ts-node compiler options in tsconfig.json. The fix directly addresses the build failure reported in the previous review.


tsconfig.json — Fix Analysis

  "ts-node": {
    "compilerOptions": {
-     "module": "CommonJS"
+     "module": "CommonJS",
+     "types": ["node"]
    }
  }

The fix is correct. Both scripts (copy-image.ts, copy-pretendard.ts) use fs, path, __dirname, and process — all provided by @types/node. The main tsconfig.json uses moduleResolution: "bundler" with lib: ["dom", "dom.iterable", "esnext"] (browser target), so Node globals were never exposed there. TypeScript 6 tightened type resolution behavior, causing ts-node to fail without the explicit types override.

@types/node@^25.9.3 is present in devDependencies, so the types are available.


Potential Concerns

1. ts-node 10.x compatibility with TypeScript 6

ts-node@10.9.2 predates TypeScript 6. While pnpm resolved ts-node@10.9.2(@types/node@25.9.3)(typescript@6.0.3) successfully (a good sign), ts-node 10.x is not officially tested against TypeScript 6. The project should monitor for subtle ts-node issues (e.g., decorator handling, import type edge cases) during actual script execution.

If issues arise, the modern replacement is tsx (npx tsx scripts/...), which has no TypeScript peer dependency restrictions. Fix this →

2. Pre-existing async bug in scripts/copy-image.ts (not introduced by this PR)

// scripts/copy-image.ts:32
fs.readdirSync(srcDir).forEach(async (file) => {
  // ...
  await copyImage(imagePath, copyPath)
  processedFiles.push(file)          // ← runs after await, but forEach doesn't await it
})
console.log(`✅ Images processed: ${processedFiles.length}`)  // ← always 0!

Array.prototype.forEach ignores the returned Promise, so all await copyImage(...) calls fire but are never awaited before the console.log. The images are still copied (the I/O completes eventually) but the counts are always 0. This doesn't block the build since ts-node doesn't wait for the script process to drain either — but it's misleading output and could mask copy failures.


Lockfile Review

pnpm-lock.yaml is correctly updated: all 49 changed lines are peer-dependency suffix renames (typescript@5.9.3typescript@6.0.3) in snapshot keys. No packages were added or removed. This is the expected mechanical change for a TypeScript version bump.


Verdict

Safe to merge. The tsconfig fix is minimal and correct. The two remaining items are either a monitoring note (ts-node 10.x / TS6 compatibility — low risk) or a pre-existing issue not related to this PR.

@get6

get6 commented Jun 22, 2026

Copy link
Copy Markdown
Owner

TypeScript 6 build 실패 수정 내용을 올렸습니다.

  • 변경: ts-node 전용 compilerOptions.typesnode를 추가해 scripts/copy-pretendard.tsfs, path, __dirname, process 타입을 찾도록 했습니다.
  • 검증:
    • pnpm install --frozen-lockfile 통과
    • pnpm lint 통과 (기존 @next/next/no-img-element warning 5개)
    • pnpm build 통과, SSG 685/685
    • git diff --check origin/main...HEAD 통과
    • git status --short --branch clean
  • 남은 리스크: GitHub Claude Code Review / review check가 새 head에서 아직 진행 중입니다. Dependabot auto-merge / automerge는 skipped입니다.
  • 다음 게이트: GitHub review check 완료 후 human merge 판단.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant