Skip to content

temporary: only check changelogs #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supalarry merged 1 commit into from
Aug 14, 2023
Merged

temporary: only check changelogs #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions source/events/issue_handler/actions/created/commands/go/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ export const go = async (payload: IssueCommentEvent, installationId: number, oct
return;
}

await setupRepositoryLocally(payload, installationId, octokit);
// await setupRepositoryLocally(payload, installationId, octokit);

const breakingChangesReports = await getBreakingChangesReports(updatedDependencies);

Logger.info(`Prepared breaking changes reports`, {
repository: payload.repository.full_name,
PR: `#${payload.issue.number}`,
Expand All @@ -41,16 +42,21 @@ export const go = async (payload: IssueCommentEvent, installationId: number, oct

await reportBreakingChangesReports(breakingChangesReports, payload, octokit);

await postRefactorsLoading(payload, octokit);
const refactorsReports = await getRefactorsReports(breakingChangesReports, payload);
await reportRefactorsReports(refactorsReports, payload, octokit);
// await postRefactorsLoading(payload, octokit);
// const refactorsReports = await getRefactorsReports(breakingChangesReports, payload);
// await reportRefactorsReports(refactorsReports, payload, octokit);

await upsertDatabaseState(
payload,
refactorsReports.map((refactor) => refactor.dependencyUpdate)
breakingChangesReports.map((update) => update.dependencyUpdate)
);

await deleteRepositoryLocally(payload);
// await upsertDatabaseState(
// payload,
// refactorsReports.map((refactor) => refactor.dependencyUpdate)
// );

// await deleteRepositoryLocally(payload);
};

function allVersionsChecked(updatedDependencies: DependencyUpdate[]): boolean {
Expand Down
16 changes: 15 additions & 1 deletion source/events/issue_handler/actions/created/commands/go/source/breaking-changes/report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,20 @@ export async function reportBreakingChangesReports(
octokit: Octokit
): Promise<void> {
let counter = 1;

if (breakingChangesReports.every((report) => report.breakingChanges.length === 0)) {
const loadingCommentId = await getBreakingChangesLoadingCommentId(payload, octokit);
const message = `:white_check_mark:&nbsp;&nbsp;All versions checked successfully! This PR looks good to me!\n\n`;

if (loadingCommentId) {
await updateComment(payload.repository.full_name, loadingCommentId, message, octokit);
} else {
await postComment(payload.repository.full_name, payload.issue.number, message, octokit);
}

return;
}

for (const report of breakingChangesReports) {
const message = await getBreakingChangesMessage(report.dependencyUpdate, report.breakingChanges);

Expand All @@ -41,7 +55,7 @@ async function getBreakingChangesMessage(dependencyUpdate: DependencyUpdate, bre
if (breakingChanges.length) {
const releaseUrl = await getReleaseUrl(dependencyUpdate.dependencyRepoUrl, dependencyUpdate.cursorVersion);

message = `:information_source:&nbsp;&nbsp;Breaking Changes in the Dependency's Changelog\n\nPackage: [${dependencyUpdate.dependencyName}](${dependencyUpdate.dependencyUrl})\nVersion: [${dependencyUpdate.cursorVersion}](${releaseUrl})\n`;
message = `:information_source:&nbsp;&nbsp;Breaking Changes in the Dependency's Changelog. Check breaking changes and run \`/adaptly go\` to continue checking next versions.\n\nPackage: [${dependencyUpdate.dependencyName}](${dependencyUpdate.dependencyUrl})\nVersion: [${dependencyUpdate.cursorVersion}](${releaseUrl})\n`;

let breakingChangeNumber = 1;

Expand Down