fix: prevent overlapping PR feedback runs - #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incident
PR #119 received the same feedback through relay, review polling, and mention polling before the first run persisted its addressed marker. Four agent runs overlapped for one effective request. Source-scoped event IDs prevented redelivery within each source but did not coordinate across sources.
Verification
@getdevintern/code: 1,293 tests passedBehavior
When relay long-polls are healthy, review and mention acquisition yield to relay. A safety sweep still runs every 30 minutes. If no successful relay poll is observed for at least 90 seconds or two configured poll intervals, whichever is longer, normal feedback polling resumes. Multiple acquisition events for the same PR share one active run and request at most one follow-up fetch after it completes.