Improve file uploads - #694
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances file upload support across the panel by enabling multipart forms, centralizing upload logic in the FileUploader service, and adding path鈥恠afety checks.
- Add
enctype="multipart/form-data"to panel option forms - Introduce
Path::isRelativeToand enforce base鈥恉estination validation inFileUploader - Refactor controllers to use
FileUploaderand remove deprecated upload helpers
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| panel/views/options/system.php | Added enctype for file uploads |
| panel/views/options/site.php | Added enctype for file uploads |
| formwork/src/Utils/Path.php | New isRelativeTo helper to compare absolute paths |
| formwork/src/Panel/Controllers/UsersController.php | Refactored user image upload to use injected FileUploader |
| formwork/src/Panel/Controllers/PagesController.php | Replaced processPageUploads with FileUploader::upload calls |
| formwork/src/Panel/Controllers/OptionsController.php | Updated options upload flow to use FileUploader |
| formwork/src/Panel/Controllers/FilesController.php | Replaced processFileUpload with FileUploader::upload calls |
| formwork/src/Panel/Controllers/AbstractController.php | Injected FileUploader dependency |
| formwork/src/Files/Services/FileUploader.php | Changed upload() signature; added destination safety check |
| formwork/fields/upload.php | Extended upload field config and validation closures |
| formwork/config/system.yaml | Configured file upload base destinations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.