Add closure signature and backtrace parameters to the debug functionality - #710
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the debug functionality by adding a display of closure signatures and backtrace parameters while introducing additional styling.
- Renames trace variables to frame for improved clarity and adjusts the filtering logic in error views.
- Implements a detailed closure signature and metadata display in the Debug functionality.
- Adds new CSS styles for better visualization of backtrace parameters.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| panel/views/errors/error.php | Renames $trace to $frame and updates the filtering condition in the backtrace loop. |
| formwork/views/errors/partials/header.php | Adds CSS rules for styling backtrace parameters. |
| formwork/views/errors/partials/debug.php | Applies similar backtrace rendering improvements as in error.php. |
| formwork/src/Debug/Debug.php | Adds closure signature generation with backtrace metadata output. |
| formwork/src/Debug/CodeDumper.php | Introduces dumpBacktraceFrame and new CSS for trace call and parameters. |
Comments suppressed due to low confidence (1)
panel/views/errors/error.php:36
- The updated filtering condition now uses '||' instead of the previous '&&', which means a frame will be displayed if either the file or the line differs from the throwable. Please confirm that this change in logic is intentional.
<?php if (isset($frame['file'], $frame['line']) && ($frame['file'] !== $throwable->getFile() || $frame['line'] !== $throwable->getLine())): ?>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.