Rename system.pages.content.safeMode to system.page.content.allowHtml - #711
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the Markdown HTML-sanitization option from system.pages.content.safeMode to system.pages.content.allowHtml and updates all associated code, schema, and translations.
- Replaced
safeModetoggle withallowHtmlin translations and config/schema - Updated parser and view code to use
allowHtmland inverted default - Adjusted default in
formwork/config/system.yamlaccordingly
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| panel/translations/*.yaml | Renamed panel.options.system.content.safeMode keys to …allowHtml across all languages |
| formwork/src/Parsers/Markdown.php | Replaced $safeMode with $allowHtml, updated default logic |
| formwork/src/Parsers/Extensions/CommonMark/FormworkExtension.php | Renamed schema entry from safeMode to allowHtml |
| formwork/schemes/config/system.yaml | Swapped pages.content.safeMode field for pages.content.allowHtml toggle |
| formwork/fields/markdown.php | Updated Markdown field to pull system.pages.content.allowHtml |
| formwork/config/views/methods.php | Changed view helper to pass allowHtml instead of safeMode |
| formwork/config/system.yaml | Renamed default pages.content.safeMode setting to allowHtml |
Comments suppressed due to low confidence (1)
panel/translations/en.yaml:157
- The description implies HTML is never allowed, which contradicts the new
allowHtmltoggle. It should explain that tags are only escaped when HTML is not allowed.
panel.options.system.content.allowHtml.description: Potentially dangerous tags like `<script>` and `<style>` are always converted to text
| public static function parse(string $input, array $options = []): string | ||
| { | ||
| $safeMode = $options['safeMode'] ?? true; | ||
| $allowHtml = $options['allowHtml'] ??= false; |
There was a problem hiding this comment.
Using the null-coalescing assignment operator here mutates the input options array and can be confusing. Consider simply using $allowHtml = $options['allowHtml'] ?? false; to avoid side effects.
Suggested change
| $allowHtml = $options['allowHtml'] ??= false; | |
| $allowHtml = $options['allowHtml'] ?? false; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.