Add the possibility to specify layout section order - #788
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the Layout and Section classes to support custom ordering of sections in layout fields.
Key changes:
- Section class now implements the Arrayable interface for better data serialization
- Added an
order()method to Section class to retrieve section order values - Layout class now lazily initializes and automatically sorts sections by their order value
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| formwork/src/Fields/Layout/Section.php | Implements Arrayable interface, adds DataArrayable trait, and introduces order() method for section ordering |
| formwork/src/Fields/Layout/Layout.php | Refactors constructor to use promoted properties and implements lazy initialization of sections with automatic sorting |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the
LayoutandSectionclasses within the layout fields system. The main focus is on optimizing how sections are handled, specifically by enabling dynamic sorting and enhancing data interoperability.Enhancements to section handling and layout construction:
Layoutclass now lazily initializes itssectionsproperty and ensures sections are always sorted by theirordervalue, improving both performance and consistency when accessing sections. [1] [2]Sectionclass now implements theArrayableinterface and uses theDataArrayabletrait, making it easier to convert section data to arrays for serialization or further processing.order()method was added to theSectionclass, which retrieves the section's order for sorting, defaulting toPHP_INT_MAXif not set. This supports the new sorting logic inLayout.