fix(deps): the dev dependency on core declares a range instead of anything - #11
Merged
Merged
Conversation
…thing
`milpa/core` sat in `require-dev` as `*` — a constraint that admits 1.0, 2.0
and every major after them, whose contract this package has never seen. The
family writes `>=X <1.0`, and thirteen siblings already do; this is one of
seven still saying `*`.
Nothing moves to `require`, and that is the measured answer, not a judgement
call: src imports nothing from `milpa/*` at all. Its nine files contain zero
`use` statements (positive control on the same grep: nine `namespace` lines),
and the only non-`Milpa\Data` symbol anywhere in src or tests is a
`{@see \Milpa\Live\...}` cross-reference in the prose of a PagesResults
docblock — the family docs generator leaves every `{@see}` unrendered,
including this package's own, so it links nothing and requires nothing.
The one consumer of `milpa/core` here is `tools/gen-docs.php`, which runs the
family generator (`Milpa\Docs\SiteGenerator`) shipped inside core's dist — a
dev-only tool, and the reason for `autoload-dev`'s `Milpa\Docs\` mapping.
The floor is measured, not assumed: with core pinned to v0.6.2 the generator
still produced its 10 pages, so `>=0.6.2 <1.0` is a range this package has been
run against at both ends, and it is the same floor `agent`, `container`,
`devtools`, `http`, `ops`, `resolver` and `workflow` declare.
Suite unchanged either way: 120 tests, 233 assertions, 28 skipped without a
local MySQL (CI runs the 8.0 service). PHPStan clean, docblocks OK,
composer validate --strict valid.
Greenhouse evidence/0571 filed this as a residue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
milpa/coresat inrequire-devas*— a constraint that admits 1.0, 2.0 and every major after them, whose contract this package has never seen. The family writes>=X <1.0; thirteen siblings already do, and this is one of seven still saying*.Nothing moves to
require, and that is the measured answer.srcimports nothing frommilpa/*at all: its nine files contain zerousestatements — positive control on the same grep, ninenamespacelines — and the only non-Milpa\Datasymbol anywhere insrcortestsis a{@see \Milpa\Live\Contracts\Component\ListsComponents}cross-reference inside the prose of aPagesResultsdocblock. That one nearly read as a hidden dependency; the generated docs settle it: the family generator leaves every{@see}unrendered, this package's own{@see RepositoryInterface}included, so the tag links nothing and requires nothing.The single consumer of
milpa/corehere istools/gen-docs.php, which runs the family generator (Milpa\Docs\SiteGenerator) shipped inside core's dist — dev-only tooling, and the reasonautoload-devmapsMilpa\Docs\intovendor/milpa/core/tools/gen-docs/.The floor is measured, not assumed. With core pinned to v0.6.2 the generator still produced its 10 pages, and it does the same on v0.12.0 — so
>=0.6.2 <1.0is a range this package has actually been run against at both ends, and it is the flooragent,container,devtools,http,ops,resolverandworkflowalready declare.*→ v0.12.0)>=0.6.2 <1.0→ v0.12.0)srccomposer validate --strictgen-docsThe 28 skips are local only — they are
MysqlRepository's integration tests, and CI runs the MySQL 8.0 service that unskips them.Closes a residue greenhouse
evidence/0571recorded.