fix: the manifest speaks the language it ships in - #13
Merged
rodrigoteamx merged 1 commit intoSep 10, 2026
Merged
Conversation
`extra.milpa.capability` is copy a person reads, not metadata for a machine: `title`, `briefing` and every entry in `unlocks` are shown by `coa capabilities` and by the panel's Plugins section, and the operation's own schema documents `unlocks` as «what becomes possible once it is installed». This package's `persistence` capability shipped one `unlocks` entry in Spanish, sitting next to a title and a briefing in English, for as long as the manifest has existed. It now reads «the token and entity backend that config/app.php chooses». Nothing caught it, and that is the part worth fixing: the house's code-language ratchet reads `src` in the monorepo layout and never a manifest, so this string sat outside every instrument that looks at language. The check therefore lives HERE, in the package that owns the file, rather than in a gate that does not scan it — a word list of Spanish function words, run over every string in the capability, with the string that actually shipped as its positive control. The list is deliberately general: the first draft included the very words it had just translated, which would have passed its own control while saying nothing about the next one.
rodrigoteamx
deleted the
fix/the-manifest-speaks-the-language-it-ships-in
branch
September 10, 2026 19:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
extra.milpa.capabilityis copy a person reads, not metadata for a machine:title,briefingand every entry inunlocksare shown bycoa capabilitiesand by the panel's Plugins section, and the operation's own schema documentsunlocksas «what becomes possible once it is installed».This package shipped one
unlocksentry in Spanish, sitting next to a title and a briefing in English, for as long as the manifest has existed.Why nothing caught it
The house's code-language ratchet reads
srcin the monorepo layout and never a manifest — so this string sat outside every instrument that looks at language.The check therefore lives here, in the package that owns the file, rather than in a gate that does not scan it: a word list of Spanish function words run over every string in the capability, with the string that actually shipped as its positive control.
Verified adversarially — putting the old string back turns the test red and it names the joints it found (
el,que).One correction worth noting
The first draft of the word list included the very words it had just translated (
elige,protegidas,operaciones). That list would have passed its own positive control while saying nothing about the next defect. The general function words catch both shipped strings on their own, which is the proof the tailored ones were unnecessary.