fix(gcs-target): Fix incorrect upload path to GCS when it has a leading slash - #170
Merged
Conversation
…ng slash Ideally we should fix all the Craft configs to not have this leading slash but that's hard and is also a breaking change so we normalize this ourselves like old times. Fixes #169.
BYK
enabled auto-merge (squash)
January 20, 2021 13:05
tonyo
reviewed
Jan 20, 2021
| // like `//your/dir/and/file` instead of `/your/dir/and/file` | ||
| // See #169 for more information. | ||
| if (pathInBucket[0] === '/') { | ||
| pathInBucket = pathInBucket.substring(1); |
Contributor
There was a problem hiding this comment.
What about multiple leading slashes?
Is it perhaps better to do path.posix.normalize on it?
Member
Author
There was a problem hiding this comment.
Why would we ever have multiple leading slashes? Also path.posix.normalize doesn't remove leading slashes. We can do let pathInBucket = path.normalize(bucketPath.path) above which removes multiple leading slashes but not sure if this is worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally we should fix all the Craft configs to not have this leading slash but that's hard and is also a breaking change so we normalize this ourselves like old times. Fixes #169.