feat(registry-target): Allow batched updates w/ new config - #249
Conversation
Fixes #48 by introducing a new registry target config structure while keeping backward compatibility. Now we expect two dicts under the names `apps` and `sdks` where the keys the canonical names and the values are individual configs for these canonical names. It also does a single commit for all changes instead of one commit per canonical name. This new structure also has the side effect of making it very hard to miss required configuration. Tested with `craft` in dry-run mode.
There was a problem hiding this comment.
A couple questions during my first pass here ...
I see that listArtifactsForRevision occurs in stores/zeus.ts. Looks like that file is copy/pasta, and I see that it can go away at any time (right? and actually I think all of Zeus can go away basically now-ish?). Removing entirely is out of scope for this PR, of course, but just wanted to double check that we don't need to update the logic in the store here. Do we? :)
Secondly, I don't see any README update. Surely with a new config file format we should have a README update here, no?
Eh, great catch. I think Zeus stuff predates the
For sure, great catch thanks! |
Fixes #48 by introducing a new registry target config structure while
keeping backward compatibility.
Now we expect two dicts under the names
appsandsdkswhere the keysthe canonical names and the values are individual configs for these
canonical names.
It also does a single commit for all changes instead of one commit per
canonical name.
This new structure also has the side effect of making it very hard to
miss required configuration.
Tested with
craftin dry-run mode.