ref(symbol-collector): Verbose output of command - #268
Merged
Conversation
iker-barriocanal
requested review from
ahmedetefy and
vladanpaunovic
and removed request for
a team
July 13, 2021 12:54
kamilogorek
suggested changes
Jul 13, 2021
AbhiPrasad
reviewed
Jul 13, 2021
AbhiPrasad
reviewed
Jul 13, 2021
AbhiPrasad
approved these changes
Jul 14, 2021
iker-barriocanal
enabled auto-merge (squash)
July 14, 2021 12:59
kamilogorek
approved these changes
Jul 14, 2021
BYK
reviewed
Jul 27, 2021
Comment on lines
+107
to
+113
| if (cmdOutput) { | ||
| if (cmdOutput.length === 0) { | ||
| this.logger.info(`The command didn't have any output.`); | ||
| } else { | ||
| this.logger.info('Command output:\n', cmdOutput.toString()); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Feels like these should be debug instead of info?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be verbose on the output of the symbol collector call.