Skip to content

test(symcollector): Add tests for filter options - #277

Merged
iker-barriocanal merged 4 commits into
masterfrom
iker/ref/symcollector
Aug 20, 2021
Merged

test(symcollector): Add tests for filter options#277
iker-barriocanal merged 4 commits into
masterfrom
iker/ref/symcollector

Conversation

@iker-barriocanal

@iker-barriocanal iker-barriocanal commented Aug 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Clean up tests for the base artifact provider.
  • Add tests to cover more edge-cases, such as having strings, regex, and undefined on the same call.
  • Other minor changes.

@iker-barriocanal
iker-barriocanal requested a review from BYK August 17, 2021 13:01
@iker-barriocanal iker-barriocanal self-assigned this Aug 17, 2021
BYK
BYK requested changes Aug 18, 2021
View reviewed changes
Comment thread src/artifact_providers/__tests__/base.test.ts Outdated
Comment thread src/artifact_providers/__tests__/base.test.ts Outdated
Comment thread src/artifact_providers/__tests__/base.test.ts Outdated
Comment thread src/targets/symbolCollector.ts Outdated
@iker-barriocanal iker-barriocanal changed the title ref(symcollector): Add tests for filter options, and move exec check out of config ref(symcollector): Add tests for filter options Aug 19, 2021
@iker-barriocanal iker-barriocanal changed the title ref(symcollector): Add tests for filter options test(symcollector): Add tests for filter options Aug 19, 2021
@iker-barriocanal
iker-barriocanal requested a review from BYK August 19, 2021 11:29
BYK
BYK reviewed Aug 19, 2021
View reviewed changes
Comment thread src/artifact_providers/__tests__/base.test.ts Outdated
Comment thread src/artifact_providers/__tests__/base.test.ts Outdated
Comment thread src/artifact_providers/__tests__/base.test.ts Outdated
@iker-barriocanal
iker-barriocanal requested a review from BYK August 20, 2021 09:54
BYK
BYK approved these changes Aug 20, 2021
View reviewed changes

@BYK BYK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iker-barriocanal
iker-barriocanal merged commit 8b41614 into master Aug 20, 2021
@iker-barriocanal
iker-barriocanal deleted the iker/ref/symcollector branch August 20, 2021 10:03
@BYK BYK added this to the Added symbol-collector Target milestone Sep 14, 2021
@BYK BYK mentioned this pull request Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BYK BYK BYK approved these changes

Assignees

@iker-barriocanal iker-barriocanal

Labels

None yet

Projects

None yet

Milestone

Added symbol-collector Target

Development

Successfully merging this pull request may close these issues.

2 participants

@iker-barriocanal @BYK